From: Jan Kara <jack@suse.cz>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <dchinner@redhat.com>,
Surbhi Palande <csurbhi@gmail.com>,
Kamal Mostafa <kamal@canonical.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/4] vfs: Protect write paths by sb_start_write - sb_end_write
Date: Thu, 12 Jan 2012 21:11:21 +0100 [thread overview]
Message-ID: <20120112201121.GD8778@quack.suse.cz> (raw)
In-Reply-To: <FA7A1011-4312-4050-8AD5-C6060CFF3A55@dilger.ca>
On Thu 12-01-12 12:56:01, Andreas Dilger wrote:
> On 2012-01-11, at 6:20 PM, Jan Kara wrote:
> > There are three entry points which dirty pages in a filesystem. mmap (handled
> > by block_page_mkwrite()), buffered write (handled by
> > __generic_file_aio_write()), and truncate (it can dirty last partial page -
> > handled by do_truncate()). Protect these places with sb_start_write() and
> > sb_end_write().
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > fs/buffer.c | 18 ++----------------
> > fs/open.c | 6 ++++++
> > mm/filemap.c | 3 ++-
> > 3 files changed, 10 insertions(+), 17 deletions(-)
> >
> > diff --git a/fs/buffer.c b/fs/buffer.c
> > index 19d8eb7..8519405 100644
> > --- a/fs/buffer.c
> > +++ b/fs/buffer.c
> > @@ -2371,18 +2371,7 @@ int __block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
>
> The comment for __block_page_mkwrite() needs to be updated to reference
> sb_start_write() and sb_end_write() instead of vfs_check_frozen().
Thanks. Fixed.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-01-12 20:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 1:20 [PATCH 0/4] Fix filesystem freezing Jan Kara
2012-01-12 1:20 ` [PATCH 1/4] fs: Improve filesystem freezing handling Jan Kara
2012-01-12 19:53 ` Andreas Dilger
2012-01-12 20:07 ` Jan Kara
2012-01-12 22:57 ` Eric Sandeen
2012-01-12 23:15 ` Jan Kara
2012-01-13 1:26 ` Dave Chinner
2012-01-13 10:12 ` Jan Kara
2012-01-12 1:20 ` [PATCH 2/4] vfs: Protect write paths by sb_start_write - sb_end_write Jan Kara
2012-01-12 19:56 ` Andreas Dilger
2012-01-12 20:11 ` Jan Kara [this message]
2012-01-12 1:20 ` [PATCH 3/4] ext4: Protect ext4_page_mkwrite with " Jan Kara
2012-01-12 1:20 ` [PATCH 4/4] xfs: Protect xfs_file_aio_write() " Jan Kara
2012-01-12 21:29 ` Al Viro
2012-01-12 21:36 ` Jan Kara
2012-01-12 2:48 ` [PATCH 0/4] Fix filesystem freezing Dave Chinner
2012-01-12 11:30 ` Jan Kara
2012-01-13 0:09 ` Dave Chinner
2012-01-13 11:07 ` Jan Kara
2012-01-12 20:48 ` Ted Ts'o
2012-01-12 21:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112201121.GD8778@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=csurbhi@gmail.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=kamal@canonical.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).