From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Aditya Kali <adityakali@google.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] quota: Remove unnecessary definitions
Date: Mon, 23 Jan 2012 16:09:22 -0500 [thread overview]
Message-ID: <20120123210922.GA17974@thunk.org> (raw)
In-Reply-To: <1327004329-6909-1-git-send-email-jack@suse.cz>
On Thu, Jan 19, 2012 at 09:18:49PM +0100, Jan Kara wrote:
>
> Ted, after applying this patch, you'll need to run 'make depend' to fixup
> dependencies in makefiles. I didn't include that in the patch because on my
> system the dependencies are different and so diff is 1500+ lines.
>
> Also I've talked with Aditya and there's no real reason for libquota to be a
> separate library. So I think it would be best to just make it part of
> libext2fs. Do you agree?
My current thinking is to rename it to libinternal, and only build it
statically. It has all sorts of namespace leakage issues, and it's
not clear any programs outside of e2fsprogs would need it any way.
What do folks think?
- Ted
next prev parent reply other threads:[~2012-01-23 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 20:18 [PATCH] quota: Remove unnecessary definitions Jan Kara
2012-01-20 2:21 ` Aditya Kali
2012-01-23 21:09 ` Ted Ts'o [this message]
2012-01-24 13:56 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123210922.GA17974@thunk.org \
--to=tytso@mit.edu \
--cc=adityakali@google.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).