From: Christoph Hellwig <hch@infradead.org>
To: Curt Wohlgemuth <curtw@google.com>
Cc: xfs@oss.sgi.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] xfstests: fix msync() call in fsx.c:domapwrite()
Date: Sun, 12 Feb 2012 18:48:52 -0500 [thread overview]
Message-ID: <20120212234852.GB3848@infradead.org> (raw)
In-Reply-To: <1328642166-389-1-git-send-email-curtw@google.com>
On Tue, Feb 07, 2012 at 11:16:06AM -0800, Curt Wohlgemuth wrote:
> This explicitly sends MS_SYNC as the flag to msync() in
> fsx.c, in domapwrite(). Without this flag, the memory
> written to the mmap'ed region will not be flushed to disk;
> in fact, on Linux, calling msync() with a '0' or MS_ASYNC
> flag is a no-op.
Looks sensible to me - what exactly msync did has always been grossly
different for different operating systems, including changing meaning
on Linux a few times, so let's be explicit.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2012-02-12 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 19:16 [PATCH] xfstests: fix msync() call in fsx.c:domapwrite() Curt Wohlgemuth
2012-02-12 23:48 ` Christoph Hellwig [this message]
2012-03-31 20:12 ` [PATCH] fsx: fix msync parameters Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120212234852.GB3848@infradead.org \
--to=hch@infradead.org \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).