From: Ted Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: Only link an inode into a directory once
Date: Wed, 15 Feb 2012 17:23:42 -0500 [thread overview]
Message-ID: <20120215222342.GB20023@thunk.org> (raw)
In-Reply-To: <20120215204015.GB15164@tux1.beaverton.ibm.com>
On Wed, Feb 15, 2012 at 12:40:15PM -0800, Darrick J. Wong wrote:
>
> Yes. I took a look at the block iteration code again, and I'm
> wondering, do we need one of these:
>
> if (ret & BLOCK_ABORT)
> break;
>
> ...around lib/ext2fs/block.c, line 450?
Good spotting; it turns out there was another problem later on, where the
if (ret & BLOCK_ABORT)
break;
does the wrong thing, since we need to break out of both the for loop
*and* the while loop.
I'll send a patch which I believe will fix BLOCK_ABORT in the block
iterator for the extent case.
- Ted
next prev parent reply other threads:[~2012-02-15 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 4:47 [PATCH] libext2fs: Only link an inode into a directory once Darrick J. Wong
2012-02-15 19:25 ` Ted Ts'o
2012-02-15 20:40 ` Darrick J. Wong
2012-02-15 22:23 ` Ted Ts'o [this message]
2012-02-15 22:27 ` [PATCH] libext2fs: fix BLOCK_ABORT handling in the block iterator for extents Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215222342.GB20023@thunk.org \
--to=tytso@mit.edu \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).