From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] resize2fs: Calculate s_first_data_block into minimum filesystem size
Date: Wed, 15 Feb 2012 18:41:47 -0500 [thread overview]
Message-ID: <20120215234147.GD20023@thunk.org> (raw)
In-Reply-To: <1323353349-9675-1-git-send-email-jack@suse.cz>
On Thu, Dec 08, 2011 at 03:09:09PM +0100, Jan Kara wrote:
> calculate_minimum_resize_size() forgot to account s_first_data_block
> into minimum filesystem size. Thus in case the size of filesystem was
> such that the last group had the minimal size (50 blocks + metadata
> overhead), the code in adjust_fs_info() decided the group is unneeded,
> removed it, and in some cases the resizing then failed with ENOSPC.
>
> Fix the issue by properly accounting for s_first_data_block in
> calculate_minimum_resize_size().
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2012-02-15 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 14:09 [PATCH] resize2fs: Calculate s_first_data_block into minimum filesystem size Jan Kara
2012-02-15 23:41 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215234147.GD20023@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).