From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, psusi@ubuntu.com, sandeen@redhat.com
Subject: Re: [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode table
Date: Mon, 27 Feb 2012 00:42:27 -0500 [thread overview]
Message-ID: <20120227054227.GB9881@thunk.org> (raw)
In-Reply-To: <1330014566-2020-1-git-send-email-lczerner@redhat.com>
On Thu, Feb 23, 2012 at 05:29:25PM +0100, Lukas Czerner wrote:
> When calling e2fsck with '-E discard' option it might happen that
> valid inodes are discarded accidentally. This is because we just
> discard the part of inode table which lies past the highest used
> inode. This is terribly wrong (sorry!).
Is this description accurate? We *do* want to discard the part of the
inode table past the highest used inode number. By definition
everything past that to the end of the bg's inode table is unsued,
right? The problem was before we were using the free inode count as I
understand things.
- Ted
next prev parent reply other threads:[~2012-02-27 5:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:29 [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode table Lukas Czerner
2012-02-27 5:42 ` Ted Ts'o [this message]
2012-02-27 7:03 ` Lukas Czerner
2012-02-28 16:31 ` Eric Sandeen
2012-02-29 7:22 ` Lukas Czerner
2012-03-01 17:35 ` Eric Sandeen
2012-03-06 22:22 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227054227.GB9881@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).