* umode_t breakage in exported kernel headers
@ 2012-03-19 20:01 Mike Frysinger
2012-03-20 10:05 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2012-03-19 20:01 UTC (permalink / raw)
To: Al Viro, Duane Griffin, linux-fsdevel, linux-ext4
[-- Attachment #1: Type: Text/Plain, Size: 427 bytes --]
commit 0583fcc96bb117763c0fa74c123573c0112dec65 moved umode_t out of the
exported headers space (via the arches' asm/types.h) and into __KERNEL__
specific linux/types.h. this breaks the exported linux/ext2_fs.h
ext2_mask_flags function which uses that type. that func appears to be the
only one exported that utilizes umode_t.
should ext2_mask_flags be updated to take a __kernel_mode_t as its first arg ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: umode_t breakage in exported kernel headers
2012-03-19 20:01 umode_t breakage in exported kernel headers Mike Frysinger
@ 2012-03-20 10:05 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2012-03-20 10:05 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Duane Griffin, linux-fsdevel, linux-ext4
On Mon, Mar 19, 2012 at 04:01:53PM -0400, Mike Frysinger wrote:
> commit 0583fcc96bb117763c0fa74c123573c0112dec65 moved umode_t out of the
> exported headers space (via the arches' asm/types.h) and into __KERNEL__
> specific linux/types.h. this breaks the exported linux/ext2_fs.h
> ext2_mask_flags function which uses that type. that func appears to be the
> only one exported that utilizes umode_t.
>
> should ext2_mask_flags be updated to take a __kernel_mode_t as its first arg ?
> -mike
ITYM "unsigned short". __kernel_mode_t is wrong kernel-side and pointless
everywhere. It should *only* be used in layout of structs shared with
userland and misdefined back then. Anything new should use explicitly-sized
types (and u16 is enough for mode).
It's nearly entirely about ncp_mount_data - ipc_perm, ipc64_perm and in
several cases st_mode of stat* are arch-dependent anyway and could bloody
well use explicitly-sized types.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-20 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19 20:01 umode_t breakage in exported kernel headers Mike Frysinger
2012-03-20 10:05 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).