From: Ted Ts'o <tytso@mit.edu>
To: hpa@zytor.com
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Thierry Reding <thierry.reding@avionic-design.de>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Artem Bityutskiy <dedekind1@gmail.com>,
Andreas Dilger <aedilger@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: No longer export ext2_fs.h to user space
Date: Sat, 24 Mar 2012 17:51:52 -0400 [thread overview]
Message-ID: <20120324215152.GA32554@thunk.org> (raw)
In-Reply-To: <20120323175534.GI6589@ZenIV.linux.org.uk>
Peter,
Note that we are planning on unexporting ext2_fs.h, and then utterly
removing it from the tree (with what fs/ext2 needs being moved to
fs/ext2/ext2.h).
Someone who was compiling "the latest version" of syslinux has
submitted a kernel bugzilla entry that this was breaking due to
ext2_fs.h using umode_t which was no longer being exported by the
kernel header files. Given that ext2_fs.h is about to go ***poof***
(Al already has the changes in his vfs git tree), I thought I should
give you a heads up....
- Ted
On Fri, Mar 23, 2012 at 05:55:34PM +0000, Al Viro wrote:
> On Fri, Mar 23, 2012 at 09:13:31AM -0400, Ted Ts'o wrote:
> > On Fri, Mar 23, 2012 at 10:27:36AM +0100, Thierry Reding wrote:
> > > Since the on-disk format has been stable for quite some time, users
> > > should either use the headers provided by libext2fs or keep a private
> > > copy of this header. For the full discussion, see this thread:
> > >
> > > https://lkml.org/lkml/2012/3/21/516
> > >
> > > While at it, this commit removes all __KERNEL__ guards, which are now
> > > unnecessary.
> > >
> > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > > Cc: Jan Kara <jack@suse.cz>
> > > Cc: Ted Ts'o <tytso@mit.edu>
> > > Cc: Artem Bityutskiy <dedekind1@gmail.com>
> > > Cc: Andreas Dilger <aedilger@gmail.com>
> > > Cc: linux-ext4@vger.kernel.org
> >
> > Acked-by: "Theodore Ts'o" <tytso@mit.edu>
> >
> > Thanks!!
> >
> > Al, do you want to take this in the VFS tree, or do you want me to
> > carry this in the ext4 tree? Or Jan could carry it in the ext2 tree.
> > I don't really have strong feelings about who picks it up. I will if
> > no one else wants to...
>
> Applied. I'll probably add a followup moving most of that stuff to
> fs/ext2/ext2.h on top of that commit...
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-24 21:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:50 [PATCH] ext2: Don't export ext2_mask_flags() to user space Thierry Reding
2012-03-21 22:23 ` Jan Kara
2012-03-21 23:16 ` Ted Ts'o
2012-03-22 5:53 ` Thierry Reding
2012-03-22 6:00 ` Artem Bityutskiy
2012-03-22 16:28 ` Ted Ts'o
2012-03-22 16:47 ` Thierry Reding
2012-03-22 18:31 ` Ted Ts'o
2012-03-23 9:27 ` [PATCH] ext2: No longer export ext2_fs.h " Thierry Reding
2012-03-23 13:13 ` Ted Ts'o
2012-03-23 17:55 ` Al Viro
2012-03-24 21:51 ` Ted Ts'o [this message]
2012-03-24 22:16 ` H. Peter Anvin
2012-03-25 1:16 ` Ted Ts'o
2012-03-22 17:31 ` [PATCH] ext2: Don't export ext2_mask_flags() " Al Viro
2012-03-23 0:25 ` Andreas Dilger
2012-03-24 6:51 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 8:37 ` Al Viro
2012-03-24 17:59 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324215152.GA32554@thunk.org \
--to=tytso@mit.edu \
--cc=aedilger@gmail.com \
--cc=dedekind1@gmail.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).