From: Jan Kara <jack@suse.cz>
To: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: Ted Tso <tytso@mit.edu>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Ext4 Mailing List <linux-ext4@vger.kernel.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2 4/4] ext4: weed out ext4_write_super
Date: Mon, 2 Apr 2012 23:50:22 +0200 [thread overview]
Message-ID: <20120402215022.GB5270@quack.suse.cz> (raw)
In-Reply-To: <1333367140-28370-6-git-send-email-artem.bityutskiy@linux.intel.com>
On Mon 02-04-12 14:45:40, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> We do not depend on VFS's '->write_super()' anymore and do not need the
> 's_dirt' flag anymore. This patch weeds out 'ext4_write_super()' and the
> 's_dirt' usage in VFS.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Looks good.
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 6b45785..0818eef 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -73,7 +73,6 @@ static const char *ext4_decode_error(struct super_block *sb, int errno,
> static int ext4_remount(struct super_block *sb, int *flags, char *data);
> static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf);
> static int ext4_unfreeze(struct super_block *sb);
> -static void ext4_write_super(struct super_block *sb);
> static int ext4_freeze(struct super_block *sb);
> static struct dentry *ext4_mount(struct file_system_type *fs_type, int flags,
> const char *dev_name, void *data);
> @@ -1148,7 +1147,6 @@ static const struct super_operations ext4_nojournal_sops = {
> .dirty_inode = ext4_dirty_inode,
> .drop_inode = ext4_drop_inode,
> .evict_inode = ext4_evict_inode,
> - .write_super = ext4_write_super,
> .put_super = ext4_put_super,
> .statfs = ext4_statfs,
> .remount_fs = ext4_remount,
> @@ -4038,7 +4036,6 @@ int ext4_commit_super(struct super_block *sb, int sync)
> es->s_free_inodes_count =
> cpu_to_le32(percpu_counter_sum_positive(
> &EXT4_SB(sb)->s_freeinodes_counter));
> - sb->s_dirt = 0;
> BUFFER_TRACE(sbh, "marking dirty");
> mark_buffer_dirty(sbh);
> if (sync) {
> @@ -4144,13 +4141,6 @@ int ext4_force_commit(struct super_block *sb)
> return ret;
> }
>
> -static void ext4_write_super(struct super_block *sb)
> -{
> - lock_super(sb);
> - ext4_commit_super(sb, 1);
> - unlock_super(sb);
> -}
> -
> static int ext4_sync_fs(struct super_block *sb, int wait)
> {
> int ret = 0;
> --
> 1.7.7.6
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-04-02 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 11:45 [PATCH v2 0/4] do not use s_dirt in ext4 Artem Bityutskiy
2012-04-02 11:45 ` [PATCH v2 1/4] ext4: Remove useless marking of superblock dirty Artem Bityutskiy
2012-04-12 7:20 ` Artem Bityutskiy
2012-04-30 8:37 ` Artem Bityutskiy
2012-06-01 13:53 ` Artem Bityutskiy
2012-06-01 13:55 ` Artem Bityutskiy
2012-06-01 15:16 ` Ted Ts'o
2012-06-01 17:48 ` Artem Bityutskiy
2012-06-21 13:11 ` Artem Bityutskiy
2012-04-02 11:45 ` [PATCH v2 2/4] ext4: Convert last user of ext4_mark_super_dirty() to ext4_handle_dirty_super() Artem Bityutskiy
2012-04-02 11:45 ` Artem Bityutskiy
2012-04-02 11:45 ` [PATCH v2 3/4] ext4: remove unnecessary superblock dirtying Artem Bityutskiy
2012-04-02 21:49 ` Jan Kara
2012-04-02 11:45 ` [PATCH v2 4/4] ext4: weed out ext4_write_super Artem Bityutskiy
2012-04-02 21:50 ` Jan Kara [this message]
2012-05-18 10:25 ` [PATCH v2 0/4] do not use s_dirt in ext4 Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402215022.GB5270@quack.suse.cz \
--to=jack@suse.cz \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).