From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: add test for symlink extent
Date: Wed, 11 Apr 2012 14:07:18 -0400 [thread overview]
Message-ID: <20120411180718.GF12044@thunk.org> (raw)
In-Reply-To: <1AA51704-1130-44B6-A891-203FDCDBF83D@whamcloud.com>
On Tue, Apr 10, 2012 at 11:06:50PM -0600, Andreas Dilger wrote:
>
> My bad. I had examined some symlinks on an ext4 filesystem to see
> if they had the EXT4_EXTENTS_FL set, but didn't think to check long
> symlinks, so I assumed this was an anachronism and rewrote the patch
> description while submitting it... Originally it read:
>
> Long symlinks with the EXT4_EXTENTS_FL set should no longer be
> considered as corrupt, since these are created by default with
> new kernels using ext4 as the filesystem type. This has not
> impacted Lustre in the past because extents are only enabled on
> the OST, while symlinks are only created on the MDT where extents
> are never enabled.
>
> However, now that distros are using ext4 as the base filesystem
> type, if the lustre-patched e2fsprogs RPM is installed it will
> incorrectly consider all such long symlinks as bad and remove them.
>
> We had previously hit problems with Lustre e2fsprogs because we
> originally flagged such symlinks as errors, and there was no
> existing test which had such a symlink. The description clearly
> wasn't useful for upstream submission, but the test is still useful.
OK, I'll update the commit description and give it a try. Note that
one of the reasons why we *have* to support extent-mapped long
symlinks is for file systems with > 32-bit block numbers....
- Ted
prev parent reply other threads:[~2012-04-11 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:34 [PATCH] tests: add test for symlink extent Andreas Dilger
2012-04-11 3:45 ` Ted Ts'o
2012-04-11 5:06 ` Andreas Dilger
2012-04-11 18:07 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411180718.GF12044@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).