From: Ted Ts'o <tytso@mit.edu>
To: Aditya Kali <adityakali@google.com>
Cc: niu@whamcloud.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck,libquota: Update quota only if its inconsistent
Date: Tue, 24 Apr 2012 14:52:31 -0400 [thread overview]
Message-ID: <20120424185231.GH18865@thunk.org> (raw)
In-Reply-To: <1334347864-12662-2-git-send-email-adityakali@google.com>
On Fri, Apr 13, 2012 at 01:11:03PM -0700, Aditya Kali wrote:
> Currently fsck recomputes quotas and overwrites quota files
> whenever its run. This causes unnecessary modification of
> filesystem even when quotas were never inconsistent. We also
> lose the limits information because of this. With this patch,
> e2fsck compares the computed quotas to the on-disk quotas
> (while updating the in-memory limits) and writes out the
> quota inode only if it is inconsistent.
>
> Signed-off-by: Aditya Kali <adityakali@google.com>
Thanks, applied with one change:
> + /* Update quota information if it is inconsistent */
> + { PR_6_UPDATE_QUOTAS,
> + N_("Updating quota info for quota type %N "),
> + PROMPT_NULL, PR_PREEN_OK | PR_NO_OK },
> +
I changed "Updating" to "Update" since we will be asking a question.
- Ted
next prev parent reply other threads:[~2012-04-24 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 20:11 [PATCH] e2fsck: Fix check for hidden quota files Aditya Kali
2012-04-13 20:11 ` [PATCH] e2fsck,libquota: Update quota only if its inconsistent Aditya Kali
2012-04-24 18:52 ` Ted Ts'o [this message]
2012-04-24 18:49 ` [PATCH] e2fsck: Fix check for hidden quota files Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424185231.GH18865@thunk.org \
--to=tytso@mit.edu \
--cc=adityakali@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=niu@whamcloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).