linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Rob Landley <rob@landley.net>
Cc: Ludwig Nussel <ludwig.nussel@suse.de>,
	linux-kernel@vger.kernel.org,
	"Jan Kara (maintainer:EXT2 FILE SYSTEM)" <jack@suse.cz>,
	"Andrew Morton (maintainer:EXT3 FILE SYSTEM)"
	<akpm@linux-foundation.org>,
	"Andreas Dilger (maintainer:EXT3 FILE SYSTEM)"
	<adilger.kernel@dilger.ca>,
	"open list:EXT2 FILE SYSTEM" <linux-ext4@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] implement uid and gid mount options for ext2, ext3 and ext4
Date: Thu, 3 May 2012 13:51:44 -0400	[thread overview]
Message-ID: <20120503175144.GH18002@thunk.org> (raw)
In-Reply-To: <4FA2B0C1.4030206@landley.net>

On Thu, May 03, 2012 at 11:22:25AM -0500, Rob Landley wrote:
> > When using 'real' file systems on removable storage devices such as
> > hard disks or usb sticks people quickly face the problem that their
> > Linux users have different uids on different machines.
> 
> I still think this belongs at the VFS level, not in individual filesystems.

I agree with Rob; as much as possible, this should be done at the VFS
level.  The problem is that there will need to be at least some
support in the individual file system, since there isn't a good place
for the VFS to intercept the internal file system iget() function to
patch in the override uid/gid values.

So the question at this point is whether it's cleaner to have the
functionality split between the VFS and the file system layers (i.e.,
with the options parsing and storing the override uid/gid values in
the super_block structure) or keeping it all in the file system layer,
and accepting the duplication of code across multiple file systems.

My preference leans towards the former (pushing as much as we can into
the VFS layer), but I can see the other point of view.

Regards,

					- Ted

  parent reply	other threads:[~2012-05-03 17:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  9:10 [PATCH] implement uid and gid mount options for ext2, ext3 and ext4 Ludwig Nussel
     [not found] ` <4FA2B0C1.4030206@landley.net>
2012-05-03 17:51   ` Ted Ts'o [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-24 15:29 Ludwig Nussel
     [not found] ` <4F971936.6070809@landley.net>
2012-04-25 11:54   ` Ludwig Nussel
2012-04-25 20:10     ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503175144.GH18002@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludwig.nussel@suse.de \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).