linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext2: cleanup the comment for ext2_export_ops
Date: Mon, 14 May 2012 11:55:25 +0200	[thread overview]
Message-ID: <20120514095525.GD5353@quack.suse.cz> (raw)
In-Reply-To: <4FB0B0F4.3060908@gmail.com>

On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote:
> ext2_export_ops gets more valued fields, not get_parent only.
> Clean up the comment.
  Um, I'd just remove the whole comment. It isn't particularly informative
anyway - NULL meaning the default behavior is very common in kernel. And we
really set about half of entries anyway...

								Honza
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  fs/ext2/super.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index e1025c7..640b4c6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
>  /* Yes, most of these are left as NULL!!
>   * A NULL value implies the default, which works with ext2-like file
>   * systems, but can be improved upon.
> - * Currently only get_parent is required.
>   */
>  static const struct export_operations ext2_export_ops = {
>  	.fh_to_dentry = ext2_fh_to_dentry,
> -- 
> 1.7.1
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2012-05-14  9:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14  7:15 [PATCH] ext2: cleanup the comment for ext2_export_ops Wang Sheng-Hui
2012-05-14  9:55 ` Jan Kara [this message]
2012-05-14 23:56   ` Wang Sheng-Hui
2012-05-15  9:59     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514095525.GD5353@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shhuiw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).