From: "J. Bruce Fields" <bfields@fieldses.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] ext4: turn on i_version updates by default
Date: Mon, 14 May 2012 10:06:18 -0400 [thread overview]
Message-ID: <20120514140618.GA29902@fieldses.org> (raw)
knfsd needs i_version updates on, as will userspace nfs servers and
probably others.
The only effects are that inode->i_version is bumped (under the i_lock)
in more places, and that ->dirty_inode(I_DIRTY_DATASYNC) may be called
more frequently than once per jiffy on write (see file_update_time).
However the latter appears to be mostly a no-op in that case.
So, simplify our life and just keep this feature turned on all the time.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/ext4/super.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
If people are worried that the performance impact isn't obvious, I'll
find the time somehow to test this properly....
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e1fb1d5..a99f827 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1483,7 +1483,7 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
sbi->s_mount_flags |= EXT4_MF_FS_ABORTED;
return 1;
case Opt_i_version:
- sb->s_flags |= MS_I_VERSION;
+ /* no-op; this is on by default now */
return 1;
case Opt_journal_dev:
if (is_remount) {
@@ -2979,6 +2979,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
goto out_free_orig;
}
sb->s_fs_info = sbi;
+ sb->s_flags |= MS_I_VERSION;
sbi->s_mount_opt = 0;
sbi->s_resuid = EXT4_DEF_RESUID;
sbi->s_resgid = EXT4_DEF_RESGID;
--
1.7.9.5
next reply other threads:[~2012-05-14 14:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 14:06 J. Bruce Fields [this message]
[not found] ` <20120514140618.GA29902-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-05-14 15:02 ` [PATCH] ext4: turn on i_version updates by default Andreas Dilger
[not found] ` <9124E59E-2479-4C32-A528-3237B48DEC01-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
2012-05-14 15:23 ` J. Bruce Fields
[not found] ` <20120514152334.GB29902-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-05-14 17:27 ` Andreas Dilger
[not found] ` <14B38D68-FAE4-444A-BCD9-7EBF7E1BBFE1-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
2012-05-14 17:58 ` Ted Ts'o
[not found] ` <20120514175822.GC1439-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2012-05-14 18:33 ` Josef Bacik
[not found] ` <20120514183316.GA1894-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2012-05-14 18:48 ` Jeff Layton
[not found] ` <20120514144802.679551fa-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-05-14 18:51 ` Josef Bacik
2012-05-14 18:54 ` J. Bruce Fields
2012-05-14 19:05 ` Josef Bacik
[not found] ` <20120514190500.GC1894-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2012-05-14 21:27 ` Andreas Dilger
2012-05-15 13:28 ` Josef Bacik
2012-05-15 17:59 ` Marco Stornelli
2012-05-15 19:18 ` J. Bruce Fields
2012-05-15 17:33 ` J. Bruce Fields
2012-05-15 18:50 ` djwong
2012-05-14 23:08 ` Myklebust, Trond
[not found] ` <1337036918.2522.32.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-05-14 23:33 ` Andreas Dilger
2012-05-14 23:54 ` J. Bruce Fields
[not found] ` <20120514235432.GA3199-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-05-15 10:30 ` Jan Kara
2012-05-15 12:35 ` J. Bruce Fields
2012-05-15 14:43 ` Jan Kara
2012-05-15 0:13 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514140618.GA29902@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).