* [PATCH] debugfs: fix strtoblk for 64bit block numbers
@ 2012-05-23 23:01 Eric Sandeen
2012-05-28 2:12 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2012-05-23 23:01 UTC (permalink / raw)
To: ext4 development
# debugfs -R "icheck 4295032832" testimage
debugfs 1.42.3 (14-May-2012)
got block 4295032832 for 4295032832
got block 65536 for 4295032832
Block Inode number
65536 <block not found>
Um, that's no good.
Affects icheck, freeb, setb, testb...
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/debugfs/util.c b/debugfs/util.c
index f43b470..b07a8cc 100644
--- a/debugfs/util.c
+++ b/debugfs/util.c
@@ -298,7 +298,7 @@ unsigned long long parse_ulonglong(const char *str, const char *cmd,
*/
int strtoblk(const char *cmd, const char *str, blk64_t *ret)
{
- blk_t blk;
+ blk64_t blk;
int err;
blk = parse_ulonglong(str, cmd, "block number", &err);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] debugfs: fix strtoblk for 64bit block numbers
2012-05-23 23:01 [PATCH] debugfs: fix strtoblk for 64bit block numbers Eric Sandeen
@ 2012-05-28 2:12 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2012-05-28 2:12 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
On Wed, May 23, 2012 at 06:01:14PM -0500, Eric Sandeen wrote:
> # debugfs -R "icheck 4295032832" testimage
> debugfs 1.42.3 (14-May-2012)
> got block 4295032832 for 4295032832
> got block 65536 for 4295032832
> Block Inode number
> 65536 <block not found>
>
> Um, that's no good.
>
> Affects icheck, freeb, setb, testb...
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-28 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 23:01 [PATCH] debugfs: fix strtoblk for 64bit block numbers Eric Sandeen
2012-05-28 2:12 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).