From: Ted Ts'o <tytso@mit.edu>
To: Haogang Chen <haogangchen@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FS: ext4: fix integer overflow in alloc_flex_gd()
Date: Mon, 28 May 2012 14:24:38 -0400 [thread overview]
Message-ID: <20120528182438.GL19152@thunk.org> (raw)
In-Reply-To: <1329777684-18396-1-git-send-email-haogangchen@gmail.com>
On Mon, Feb 20, 2012 at 05:41:24PM -0500, Haogang Chen wrote:
> In alloc_flex_gd(), when flexbg_size is large, kmalloc size would
> overflow and flex_gd->groups would point to a buffer smaller than
> expected, causing OOB accesses when it is used.
>
> Note that in ext4_resize_fs(), flexbg_size is calculated using
> sbi->s_log_groups_per_flex, which is read from the disk and only bounded
> to [1, 31]. The patch returns NULL for too large flexbg_size.
>
> Signed-off-by: Haogang Chen <haogangchen@gmail.com>
Thanks, applied. Apologies for missing this during the last cycle.
- Ted
prev parent reply other threads:[~2012-05-28 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 22:41 [PATCH] FS: ext4: fix integer overflow in alloc_flex_gd() Haogang Chen
2012-02-20 23:47 ` Eric Sandeen
2012-02-21 13:55 ` Xi Wang
2012-02-21 16:36 ` Eric Sandeen
2012-02-21 17:19 ` Andreas Dilger
2012-05-28 18:24 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528182438.GL19152@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=haogangchen@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).