From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: use make rules to run tests in parallel (v3)
Date: Tue, 29 May 2012 08:33:49 -0400 [thread overview]
Message-ID: <20120529123349.GB16351@thunk.org> (raw)
In-Reply-To: <37AFC02E-AB57-4B17-906A-D5FE643B7226@whamcloud.com>
On Tue, May 29, 2012 at 01:02:11AM -0600, Andreas Dilger wrote:
>
> Hrm, one reason I made the generated files read-only is to avoid
> accidentally editing the generated copy, and then losing the resulting
> changes when the file is recreated (as happened several times with the
> test_script file, when rebasing the patch). I'd prefer to mark the
> generated files read-only, and then have the Makefile rules delete the
> file before recreating it.
I tend to just edit the foo.in file; the Makefile dependencies
automatically take care of rebuiling the test_one and test_script
files --- and it's much easier just to type "make" to retry the
generated scripts....
> That avoids accidentally having developers edit the file, while allowing
> the always-remembering Makefile rule to recreate the file without errors.
Yeah, but I don't want to encourage developers editing generated
files... it's much better to make things much more convenient for
them to do things in the "right" way. In the long run that's much
more effective at avoiding lost work, and it saves you effort (since
otherwise you might forget to fix the foo.in file before you commit
the change, etc.)
- Ted
next prev parent reply other threads:[~2012-05-29 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 22:58 [PATCH] tests: use make rules to run tests in parallel (v3) Andreas Dilger
2012-05-29 1:28 ` Ted Ts'o
2012-05-29 7:02 ` Andreas Dilger
2012-05-29 12:33 ` Ted Ts'o [this message]
2012-05-29 14:23 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529123349.GB16351@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox