From: Ted Ts'o <tytso@mit.edu>
To: Hugh Dickins <hughd@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] ext4: hole-punch use truncate_pagecache_range
Date: Fri, 1 Jun 2012 00:17:42 -0400 [thread overview]
Message-ID: <20120601041742.GG7897@thunk.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1205131342420.1547@eggly.anvils>
On Sun, May 13, 2012 at 01:47:00PM -0700, Hugh Dickins wrote:
> When truncating a file, we unmap pages from userspace first, as that's
> usually more efficient than relying, page by page, on the fallback in
> truncate_inode_page() - particularly if the file is mapped many times.
>
> Do the same when punching a hole: 3.4 added truncate_pagecache_range()
> to do the unmap and trunc, so use it in ext4_ext_punch_hole(), instead
> of calling truncate_inode_pages_range() directly.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2012-06-01 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 20:47 [PATCH] ext4: hole-punch use truncate_pagecache_range Hugh Dickins
2012-06-01 4:17 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601041742.GG7897@thunk.org \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).