* [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS.
@ 2012-06-04 3:18 Tao Ma
2012-06-07 23:05 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Tao Ma @ 2012-06-04 3:18 UTC (permalink / raw)
To: linux-ext4; +Cc: Theodore Ts'o
From: Tao Ma <boyu.mt@taobao.com>
7990696 uses the ext4_{set,clear}_inode_flags() functions to change
the i_flags automatically but fails to remove the error setting of
i_flags. So we still have the problem of trashing state flags. So
remove it.
Cc: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
fs/ext4/ioctl.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 8ad112a..e34deac 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
else
ext4_clear_inode_flag(inode, i);
}
- ei->i_flags = flags;
ext4_set_inode_flags(inode);
inode->i_ctime = ext4_current_time(inode);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-07 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 3:18 [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS Tao Ma
2012-06-07 23:05 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).