From: Al Viro <viro@ZenIV.linux.org.uk>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/4] exofs: Handle error from d_splice_alias()
Date: Fri, 8 Jun 2012 22:59:50 +0100 [thread overview]
Message-ID: <20120608215950.GQ30000@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4FC5F8CC.20400@panasas.com>
On Wed, May 30, 2012 at 01:39:08PM +0300, Boaz Harrosh wrote:
> + ret = d_splice_alias(inode, dentry);
> + if (IS_ERR(ret)) {
> + EXOFS_ERR("directory #%lu corrupted", dir->i_ino);
> + iput(inode);
That's a bloody wrong interface. If you add d_splice_alias() failure
exit like that, do iput() *there*. Requiring every caller to deal with
failure exit cleanups like that is the recipe for recurring bugs.
Don't Do That.
next prev parent reply other threads:[~2012-06-08 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 20:07 [PATCH 0/4] Avoid deadlock when corrupted directory creates a loop Jan Kara
2012-05-29 20:07 ` [PATCH 1/4] vfs: Avoid creation of directory loops for corrupted filesystems Jan Kara
2012-05-29 20:07 ` [PATCH 2/4] ext2: Handle error from d_splice_alias() Jan Kara
2012-05-29 20:07 ` [PATCH 3/4] ext3: " Jan Kara
2012-05-29 20:07 ` [PATCH 4/4] ext4: " Jan Kara
2012-05-30 10:39 ` [PATCH 5/4] exofs: " Boaz Harrosh
2012-05-30 10:40 ` Boaz Harrosh
2012-06-08 21:59 ` Al Viro [this message]
2012-06-11 15:41 ` Boaz Harrosh
2012-06-11 19:01 ` Ted Ts'o
2012-06-12 9:04 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608215950.GQ30000@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bharrosh@panasas.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).