From: Ted Ts'o <tytso@mit.edu>
To: Aditya Kali <adityakali@google.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: fix i_blocks for extent leaf create/delete
Date: Sun, 10 Jun 2012 23:53:01 -0400 [thread overview]
Message-ID: <20120611035301.GA1437@thunk.org> (raw)
In-Reply-To: <1338489118-13483-1-git-send-email-adityakali@google.com>
On Thu, May 31, 2012 at 11:31:58AM -0700, Aditya Kali wrote:
> When libext2fs allocates/deletes an extent leaf, the i_blocks
> value is incremented/decremented by fs->blocksize / 512. This
> is incorrect in case of bigalloc. The correct way here is to
> use cluster_size / 512.
> The problem is seen if we try to create a large inode using
> libext2fs (say using ext2fs_block_iterate3()) on a bigalloc
> filesystem. fsck catches this and complains.
>
> Signed-off-by: Aditya Kali <adityakali@google.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2012-06-11 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 18:31 [PATCH] libext2fs: fix i_blocks for extent leaf create/delete Aditya Kali
2012-06-11 3:53 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611035301.GA1437@thunk.org \
--to=tytso@mit.edu \
--cc=adityakali@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).