linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.ru>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: <linux-ext4@vger.kernel.org>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] E2fsprogs: add missing usage for No_COW
Date: Wed, 13 Jun 2012 14:38:17 +0600	[thread overview]
Message-ID: <20120613143817.454917c8@natsu> (raw)
In-Reply-To: <1339573633-31023-1-git-send-email-liubo2009@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Wed, 13 Jun 2012 15:47:13 +0800
Liu Bo <liubo2009@cn.fujitsu.com> wrote:

> Add the missing usage for No_COW since we've supported No_COW flag.
> 
> Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
> ---
>  misc/chattr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/misc/chattr.c b/misc/chattr.c
> index 141ea6e..24254cc 100644
> --- a/misc/chattr.c
> +++ b/misc/chattr.c
> @@ -83,7 +83,7 @@ static unsigned long sf;
>  static void usage(void)
>  {
>  	fprintf(stderr,
> -		_("Usage: %s [-RVf] [-+=AacDdeijsSu] [-v version] files...\n"),
> +		_("Usage: %s [-RVf] [-+=AacDdeijsSuC] [-v version] files...\n"),
>  		program_name);
>  	exit(1);
>  }

These were sorted alphabetically so the better way would be to use AaCcDdeijsSu

-- 
With respect,
Roman

~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-06-13  8:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13  7:47 [PATCH] E2fsprogs: add missing usage for No_COW Liu Bo
2012-06-13  8:38 ` Roman Mamedov [this message]
2012-06-14  2:47 ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613143817.454917c8@natsu \
    --to=rm@romanrm.ru \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=liubo2009@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).