From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: jeff.liu@oracle.com
Cc: linux-serial@vger.kernel.org,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
gregkh@linuxfoundation.org, Jan Kara <jack@suse.cz>,
"Ted Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH 1/2] Add a new helper for sleepable BTM acquirements which is used by tty_write_message()
Date: Sat, 30 Jun 2012 13:35:49 +0100 [thread overview]
Message-ID: <20120630133549.2431968e@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4FEEC96E.9070502@oracle.com>
On Sat, 30 Jun 2012 17:39:58 +0800
Jeff Liu <jeff.liu@oracle.com> wrote:
> This helper only used by tty_write_message(), it will sleep until BTM lock acquired.
This makes no sense at all. mutexes already sleep. Your code is also
wrong for real time processes.
So NAK.
prev parent reply other threads:[~2012-06-30 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 9:39 [PATCH 1/2] Add a new helper for sleepable BTM acquirements which is used by tty_write_message() Jeff Liu
2012-06-30 12:35 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120630133549.2431968e@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jeff.liu@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox