Re: dead/wrong code in ext3/4_releasepage()

Andrew Perepechko
2012-07-02T17:21:14Z

Hi Jan!
So you think the correct fix would be to remove the check completely
since every try_to_release_page() caller is obliged to perform the
page_has_private() check?
Thank you,
Andrew
On 07/02/2012 09:09 PM, Jan Kara wrote:
> On Fri 29-06-12 20:52:51, Andrew Perepechko wrote:
>> This does not lead to oom or any similar issue since calls to
>> try_to_release_page()
>> are accompanied by page_has_private() checks.
>>
>>
> The check is a dead code because ->release_page() is called only if
> PagePrivate bit is set.
>
> Honza