From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Tao Ma <tm@tao.ma>,
Eric Sandeen <sandeen@redhat.com>,
Robin Dong <hao.bigrat@gmail.com>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 2/3 v3] ext4: add a new flag for ext4_map_blocks
Date: Mon, 9 Jul 2012 10:49:02 -0400 [thread overview]
Message-ID: <20120709144902.GD3649@thunk.org> (raw)
In-Reply-To: <1341152506-32649-3-git-send-email-wenqing.lz@taobao.com>
On Sun, Jul 01, 2012 at 10:21:45PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> EXT4_GET_BLOCKS_NO_LOCK flag is added to indicate that we don't need to acquire
> i_data_sem lock in ext4_map_blocks. Meanwhile, it lets _ext4_get_block do not
> start a new journal because when we do a overwrite dio, there is no any
> metadata that needs to be modified.
>
> We define a new function called ext4_get_block_write_nolock, which is used in
> dio overwrite nolock. In this function, it doesn't try to acquire i_data_sem
> lock and doesn't start a new journal as it does a lookup.
>
> CC: Tao Ma <tm@tao.ma>
> CC: Eric Sandeen <sandeen@redhat.com>
> CC: Robin Dong <hao.bigrat@gmail.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2012-07-09 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 14:21 [PATCH 0/3 v3] ext4: dio overwrite nolock Zheng Liu
2012-07-01 14:21 ` [PATCH 1/3 v3] ext4: split ext4_file_write into buffered IO and direct IO Zheng Liu
2012-07-09 14:44 ` Theodore Ts'o
2012-07-01 14:21 ` [PATCH 2/3 v3] ext4: add a new flag for ext4_map_blocks Zheng Liu
2012-07-09 14:49 ` Theodore Ts'o [this message]
2012-07-01 14:21 ` [PATCH 3/3 v3] ext4: add dio overwrite nolock Zheng Liu
2012-07-09 15:01 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709144902.GD3649@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tm@tao.ma \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).