From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 05/35 v3] libext2fs: add EXT4_INLINE_DATA_FL flag for inode
Date: Mon, 16 Jul 2012 11:01:44 -0400 [thread overview]
Message-ID: <20120716150144.GA3670@thunk.org> (raw)
In-Reply-To: <1341150538-32047-6-git-send-email-wenqing.lz@taobao.com>
On Sun, Jul 01, 2012 at 09:48:28PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> Add EXT4_INLINE_DATA_FL flag.
>
> /* EXT4_EOFBLOCKS_FL 0x00400000 was here */
> +#define EXT4_INLINE_DATA_FL 0x00800000 /* Inode has inline data */
Hi,
Unfortunately, we have a codepoint collision. The BTRFS folks have
already exposed FS_NOCOW_FL as 0x00800000; this is in mainline in the
kernel, and in fact that latest version of e2fsprogs understands this
since lsattr and chattr are used by multiple file systems (even though
it was originally intended only for ext2/3/4).
I'd like to move this to:
#define EXT4_INLINE_DATA_FL 0x10000000 /* Inode has inline data */
However, if you already have this in production internally inside
Taobao, this could potentially could be a problem for you. (We've had
to handle this before inside Google, when we used a different code
point for EOFBLOCKS_FL than what ended up being used in mainline; it
can be dealt with, but it's certainly annoying...)
Is this going to potentially be a problem for you?
Regards,
- Ted
next prev parent reply other threads:[~2012-07-16 15:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 13:48 [PATCH 00/35 v3] e2fsprogs: make e2fsprogs support inline data Zheng Liu
2012-07-01 13:48 ` [PATCH 01/35 v3] libext2fs: add EXT4_FEATURE_INCOMPAT_INLINE_DATA flag Zheng Liu
2012-08-07 18:22 ` Theodore Ts'o
2012-08-07 18:25 ` Theodore Ts'o
2012-08-13 7:44 ` Zheng Liu
2012-07-01 13:48 ` [PATCH 02/35 v3] mke2fs: make it support inline data feature Zheng Liu
2012-07-01 13:48 ` [PATCH 03/35 v3] mke2fs: add inline_data feature in mke2fs's manpage Zheng Liu
2012-07-01 13:48 ` [PATCH 04/35 v3] libext2fs: add ext2fs_find_entry_ext_attr function Zheng Liu
2012-07-01 13:48 ` [PATCH 05/35 v3] libext2fs: add EXT4_INLINE_DATA_FL flag for inode Zheng Liu
2012-07-16 15:01 ` Theodore Ts'o [this message]
2012-07-17 2:20 ` Zheng Liu
2012-07-01 13:48 ` [PATCH 06/35 v3] libext2fs: add data structures for inline data feature Zheng Liu
2012-07-01 13:48 ` [PATCH 07/35 v3] libext2fs: add inline_data file Zheng Liu
2012-07-01 13:48 ` [PATCH 08/35 v3] debugfs: make ncheck cmd support inline data Zheng Liu
2012-07-01 13:48 ` [PATCH 09/35 v3] debugfs: make icheck " Zheng Liu
2012-07-01 13:48 ` [PATCH 10/35 v3] debugfs: make chroot and cd " Zheng Liu
2012-07-01 13:48 ` [PATCH 11/35 v3] debugfs: make ls " Zheng Liu
2012-07-01 13:48 ` [PATCH 12/35 v3] debugfs: make stat " Zheng Liu
2012-07-01 13:48 ` [PATCH 13/35 v3] debugfs: make blocks " Zheng Liu
2012-07-01 13:48 ` [PATCH 14/35 v3] debugfs: make filefrag " Zheng Liu
2012-07-01 13:48 ` [PATCH 15/35 v3] debugfs: make link " Zheng Liu
2012-07-01 13:48 ` [PATCH 16/35 v3] debugfs: make unlink " Zheng Liu
2012-07-01 13:48 ` [PATCH 17/35 v3] debugfs: make mkdir " Zheng Liu
2012-07-01 13:48 ` [PATCH 18/35 v3] debugfs: make rmdir " Zheng Liu
2012-07-01 13:48 ` [PATCH 19/35 v3] debugfs: make rm and kill_file " Zheng Liu
2012-07-01 13:48 ` [PATCH 20/35 v3] debugfs: make pwd " Zheng Liu
2012-07-01 13:48 ` [PATCH 21/35 v3] debugfs: make expand_dir " Zheng Liu
2012-07-01 13:48 ` [PATCH 22/35 v3] debugfs: make lsdel " Zheng Liu
2012-07-01 13:48 ` [PATCH 23/35 v3] debugfs: make undelete " Zheng Liu
2012-07-01 13:48 ` [PATCH 24/35 v3] debugfs: make dump and cat " Zheng Liu
2012-07-01 13:48 ` [PATCH 25/35 v3] debugfs: make rdump " Zheng Liu
2012-07-01 13:48 ` [PATCH 26/35 v3] debugfs: make dirsearch " Zheng Liu
2012-07-01 13:48 ` [PATCH 27/35 v3] debugfs: make bmap " Zheng Liu
2012-07-01 13:48 ` [PATCH 28/35 v3] debugfs: make punch/truncate " Zheng Liu
2012-07-01 13:48 ` [PATCH 29/35 v3] e2fsck: add three problem descriptions in pass1 Zheng Liu
2012-07-01 13:48 ` [PATCH 30/35 v3] e2fsck: check incorrect inline data flag Zheng Liu
2012-07-01 13:48 ` [PATCH 31/35 v3] e2fsck: make pass1 support inline data Zheng Liu
2012-07-01 13:48 ` [PATCH 32/35 v3] libext2fs: add read/write inline data functions Zheng Liu
2012-07-01 13:48 ` [PATCH 33/35 v3] e2fsck: check inline data in pass2 Zheng Liu
2012-07-01 13:48 ` [PATCH 34/35 v3] mke2fs: enable inline_data feature on ext4dev filesystem Zheng Liu
2012-07-01 13:48 ` [PATCH 35/35 v3] tests: change test f_bad_disconnected_inode to support inline_data feature Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716150144.GA3670@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).