public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Kevin Shanahan <kmshanah@disenchant.net>
Cc: Andreas Dilger <aedilger@gmail.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: Ext4 external journal UUID mismatch?
Date: Mon, 16 Jul 2012 11:40:46 -0400	[thread overview]
Message-ID: <20120716154046.GB27656@thunk.org> (raw)
In-Reply-To: <20120716100010.GC2562@tuon.disenchant.local>

On Mon, Jul 16, 2012 at 07:30:10PM +0930, Kevin Shanahan wrote:
> > The lookup of the journal by UUID (instead of relying on the "device
> > hint" in the superblock) _should_ be handled by mount, but I don't
> > recall if we ever got a mount.ext4 to handle this or not. It would
> > also be possible for the "fast e2fsck" check to verify the journal
> > UUID before mounting the filesystem, but again I'm not sure if this
> > is done yet, and I can't check right now.
> 
> Ok, thanks. For now I can ask LVM to make the major/minor number
> persistent.
> 
> Assuming it's not already done, do you think adding the UUID lookup
> would be a reasonable project for a newbie or is it likely to be a bit
> complicated?

We have a mount option.  You can specify it via a mount option, i.e.,

   -o journal_dev=0xFC02

It would be nice if the mount program (in util-linux) did a uuid
lookup using the blkid library if there was a mount option string of
the form "journal_dev=lookup".

I would certainly support getting a feature like that into mount
command, but it would be up to the maintainer of the util-linux
package to approve the specific patch.  Since it would require linking
in the ext2fs library, or putting in enough knowledge of the ext3/4
superblock to fetch the external journal uuid, I could imagine the
util-linux maintainer insisting that this be done in a helper program
(i.e., /sbin/mount.ext3 and /sbin/mount.ext4).  So it could
potentially get a little complicated, just to warn you ahead of time.

Regards,

					- Ted

      parent reply	other threads:[~2012-07-16 15:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-15 23:40 Ext4 external journal UUID mismatch? Kevin Shanahan
2012-07-16  2:56 ` Kevin Shanahan
2012-07-16  4:32   ` Andreas Dilger
2012-07-16 10:00     ` Kevin Shanahan
2012-07-16 14:13       ` Andreas Dilger
2012-07-16 15:40       ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716154046.GB27656@thunk.org \
    --to=tytso@mit.edu \
    --cc=aedilger@gmail.com \
    --cc=kmshanah@disenchant.net \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox