From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: How should e2fsck clear s_errno/j_errno on an ro mount?
Date: Sat, 28 Jul 2012 23:51:18 -0400 [thread overview]
Message-ID: <20120729035118.GA17210@thunk.org> (raw)
In-Reply-To: <500DB259.8070901@redhat.com>
On Mon, Jul 23, 2012 at 03:21:45PM -0500, Eric Sandeen wrote:
>
> If make the first test above a little later:
>
> ...
>
>
> it clears it up for me but TBH I'm not totally clear on what all is going
> on here.
Your patch effectively reverts commit 47c1b8e1666: e2fsck: Skip journal
checks if the fs is mounted and doesn't need recovery
The reason why this patch was added was that it slightly speeded up
the HDD boots. I've looked at this closely, and it's really not that
big of a speed up. It only saves a single seek and read (to read the
journal superblock). I've measured what it would be on a 1TB laptop
drive, and the difference is 60ms (70ms versus 10ms).
So I'm going to revert that commit, which should fix the problem that
we're seeing. But it also turns out that the kernel is not quite
doing the right thing. It should have never left the journal
superblock with a non-zero s_error indicator after it transfered the
error indicator to the superblock. The problem was that we weren't
actually flushing the cleared errno field out to the disk for the
journal superblock.
- Ted
next prev parent reply other threads:[~2012-07-29 3:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 23:13 How should e2fsck clear s_errno/j_errno on an ro mount? Eric Sandeen
2012-07-21 0:39 ` Theodore Ts'o
2012-07-23 16:28 ` Eric Sandeen
2012-07-23 19:14 ` Theodore Ts'o
2012-07-23 20:21 ` Eric Sandeen
2012-07-29 3:51 ` Theodore Ts'o [this message]
2012-07-29 3:52 ` [PATCH] ext4: make sure the journal sb is written in ext4_clear_journal_err() Theodore Ts'o
2012-07-29 4:13 ` [PATCH] Revert "e2fsck: Skip journal checks if the fs is mounted and doesn't need recovery" Theodore Ts'o
2012-07-29 4:19 ` [PATCH] e2fsck: check a file system mounted read-only if forced Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729035118.GA17210@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).