linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: semenko@syndetics.net, linux-ext4@vger.kernel.org,
	semenko@alum.mit.edu, mangoo@wpkg.org, djwong@us.ibm.com
Subject: Re: "Unknown code" error when enabling metadata_csum on ext4 raid1 device
Date: Fri, 3 Aug 2012 00:01:15 -0400	[thread overview]
Message-ID: <20120803040115.GC4253@thunk.org> (raw)
In-Reply-To: <20120801071935.GA12929@gmail.com>

On Wed, Aug 01, 2012 at 03:19:35PM +0800, Zheng Liu wrote:
> Subject: [PATCH] tune2fs: clear error code before rewriting directory when metadata_csum enabled
> 
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> When we enable metadata_csum feature in tune2fs, all inodes need to be rewrited
> to calculate checksum.  In this process, the inode that has been removed also
> needs to calculate checksum, but the extent tree in these inodes has been clear.
> Thus, we cannot read any extents, and an 'EXT2_ET_EXTENT_NO_NEXT' error is
> returned back.  But in this condition error code in rewrite_dir_context doesn't
> be initialized, and it causes an unknown error.

Thanks, I've merged this into my e2fsprogs checksum branch.

I've promoted all of the metadata checksum patches in e2fsprogs into
the next branch.  

At that point I'll strongly suggest that people use the development
branch (currently the next branch, but in the next or two, the master
branch) of e2fsprogs.  For the kernel, for now I suggest using the
v3.5 kernel with the ext4_for_linus (commit 03179fe92318) from the
ext4.git tree merged in.  Hopefully the necessary bug fix commits will
be in the v3.5.1 kernel, but the 3.5.y series hasn't been released
yet.

						- Ted

      parent reply	other threads:[~2012-08-03  4:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  2:53 "Unknown code" error when enabling metadata_csum on ext4 raid1 device Nick Semenkovich
2012-08-01  7:19 ` Zheng Liu
2012-08-01  7:16   ` Tomasz Chmielewski
2012-08-01  7:48     ` Zheng Liu
2012-08-01  7:51       ` Tomasz Chmielewski
2012-08-01  8:17         ` Zheng Liu
2012-08-02  3:43           ` Nick Semenkovich
2012-08-02  9:58             ` Zheng Liu
2012-08-03  4:01   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120803040115.GC4253@thunk.org \
    --to=tytso@mit.edu \
    --cc=djwong@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mangoo@wpkg.org \
    --cc=semenko@alum.mit.edu \
    --cc=semenko@syndetics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).