From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: add max_dir_size_kb mount option
Date: Fri, 10 Aug 2012 17:59:59 -0400 [thread overview]
Message-ID: <20120810215959.GB1137@thunk.org> (raw)
In-Reply-To: <50256C39.4030502@redhat.com>
On Fri, Aug 10, 2012 at 03:16:57PM -0500, Eric Sandeen wrote:
>
> Oh, I thought this was papering over a scaling problem in ext4. The intent
> is to protect userspace from arbitrarily large readdir results?
The problem that arose was that the directory had grown to 176mb, and
in a tight memory cgroup (say, 512mb, or some such), this could cause
significant memory thrashing, or the actual OOM killing of the task in
said tight memory cgroup when it tried to read the entire directory
via readdir().
> If that's the case, this should probably be proposed as a VFS level
> option, and see how it's received there...
It's not really a VFS level thing, since the goal is to stop the
directory size itself from growing beyond a size limit (say, 1mb).
- Ted
next prev parent reply other threads:[~2012-08-10 22:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 19:23 [PATCH] ext4: add max_dir_size_kb mount option Theodore Ts'o
2012-08-10 19:38 ` Eric Sandeen
2012-08-10 19:59 ` Theodore Ts'o
2012-08-10 20:16 ` Eric Sandeen
2012-08-10 21:59 ` Theodore Ts'o [this message]
2012-08-10 20:11 ` Jeff Moyer
2012-08-10 21:58 ` Theodore Ts'o
2012-08-10 23:14 ` Andreas Dilger
2012-08-11 1:40 ` [PATCH -v2] " Theodore Ts'o
2012-08-11 3:22 ` Andreas Dilger
2012-08-11 19:26 ` Theodore Ts'o
2012-08-11 21:10 ` Andreas Dilger
2012-08-11 21:13 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810215959.GB1137@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).