From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 06/36 v4] libext2fs: add data structures for inline data feature
Date: Mon, 13 Aug 2012 16:10:03 +0800 [thread overview]
Message-ID: <20120813081003.GC21093@gmail.com> (raw)
In-Reply-To: <20120807185053.GA30272@thunk.org>
On Tue, Aug 07, 2012 at 02:50:53PM -0400, Theodore Ts'o wrote:
> On Tue, Jul 31, 2012 at 07:47:59PM +0800, Zheng Liu wrote:
> > +struct ext2_ext_attr_ibody_header {
> > + __u32 h_magic;
> > +};
> > +
>
> I've searched through the entire patch series, and I don't find any
> usage of h_magic, and in fact the only place this structure definition
> is used is in ext2fs_get_inline_xattr_pos().
>
> So that's a bit worrying; if this is a magic number, then it should be
> checked (and an error returned if the magic number is not what we
> expect it tobe). Add checks into e2fsck would also be a really good
> idea. Also, what is the value that h_magic is epxected to be? It
> needs to be defined here.
>
> It's also clear from looking at this function that this patch
> significantly changes the layout of the extended attribute block of
> data. It would be a really good idea to add some ascii art to
> document exactly what is going on. A diagram so it's obvious to
> future developers about the data layout is really needed.
Thanks, I will fix it.
Regards,
Zheng
next prev parent reply other threads:[~2012-08-13 8:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 11:47 [PATCH 00/36 v4] e2fsprogs: make e2fsprogs support inline data Zheng Liu
2012-07-31 11:47 ` [PATCH 01/36 v4] libext2fs: add EXT4_FEATURE_INCOMPAT_INLINE_DATA flag Zheng Liu
2012-07-31 11:47 ` [PATCH 02/36 v4] mke2fs: make it support inline data feature Zheng Liu
2012-07-31 11:47 ` [PATCH 03/36 v4] mke2fs: add inline_data feature in mke2fs's manpage Zheng Liu
2012-07-31 11:47 ` [PATCH 04/36 v4] libext2fs: add ext2fs_find_entry_ext_attr function Zheng Liu
2012-07-31 11:47 ` [PATCH 05/36 v4] libext2fs: add EXT4_INLINE_DATA_FL flag for inode Zheng Liu
2012-08-07 18:27 ` Theodore Ts'o
2012-07-31 11:47 ` [PATCH 06/36 v4] libext2fs: add data structures for inline data feature Zheng Liu
2012-08-07 18:50 ` Theodore Ts'o
2012-08-13 8:10 ` Zheng Liu [this message]
2012-07-31 11:48 ` [PATCH 07/36 v4] libext2fs: add inline_data file Zheng Liu
2012-08-07 18:40 ` Theodore Ts'o
2012-08-13 8:07 ` Zheng Liu
2012-07-31 11:48 ` [PATCH 08/36 v4] debugfs: make ncheck cmd support inline data Zheng Liu
2012-07-31 11:48 ` [PATCH 09/36 v4] debugfs: make icheck " Zheng Liu
2012-07-31 11:48 ` [PATCH 10/36 v4] debugfs: make chroot and cd " Zheng Liu
2012-07-31 11:48 ` [PATCH 11/36 v4] debugfs: make ls " Zheng Liu
2012-07-31 11:48 ` [PATCH 12/36 v4] debugfs: make stat " Zheng Liu
2012-07-31 11:48 ` [PATCH 13/36 v4] debugfs: make blocks " Zheng Liu
2012-07-31 11:48 ` [PATCH 14/36 v4] debugfs: make filefrag " Zheng Liu
2012-07-31 11:48 ` [PATCH 15/36 v4] debugfs: make link " Zheng Liu
2012-07-31 11:48 ` [PATCH 16/36 v4] debugfs: make unlink " Zheng Liu
2012-07-31 11:48 ` [PATCH 17/36 v4] debugfs: make mkdir " Zheng Liu
2012-07-31 11:48 ` [PATCH 18/36 v4] debugfs: make rmdir " Zheng Liu
2012-07-31 11:48 ` [PATCH 19/36 v4] debugfs: make rm and kill_file " Zheng Liu
2012-07-31 11:48 ` [PATCH 20/36 v4] debugfs: make pwd " Zheng Liu
2012-07-31 11:48 ` [PATCH 21/36 v4] debugfs: make expand_dir " Zheng Liu
2012-07-31 11:48 ` [PATCH 22/36 v4] debugfs: make lsdel " Zheng Liu
2012-07-31 11:48 ` [PATCH 23/36 v4] debugfs: make undelete " Zheng Liu
2012-07-31 11:48 ` [PATCH 24/36 v4] debugfs: make dump and cat " Zheng Liu
2012-07-31 11:48 ` [PATCH 25/36 v4] debugfs: make rdump " Zheng Liu
2012-07-31 11:48 ` [PATCH 26/36 v4] debugfs: make dirsearch " Zheng Liu
2012-07-31 11:48 ` [PATCH 27/36 v4] debugfs: make bmap " Zheng Liu
2012-07-31 11:48 ` [PATCH 28/36 v4] debugfs: make punch/truncate " Zheng Liu
2012-07-31 11:48 ` [PATCH 29/36 v4] e2fsck: add three problem descriptions in pass1 Zheng Liu
2012-07-31 11:48 ` [PATCH 30/36 v4] e2fsck: check incorrect inline data flag Zheng Liu
2012-07-31 11:48 ` [PATCH 31/36 v4] e2fsck: make pass1 support inline data Zheng Liu
2012-07-31 11:48 ` [PATCH 32/36 v4] libext2fs: add read/write inline data functions Zheng Liu
2012-07-31 11:48 ` [PATCH 33/36 v4] e2fsck: check inline data in pass2 Zheng Liu
2012-07-31 11:48 ` [PATCH 34/36 v4] mke2fs: enable inline_data feature on ext4dev filesystem Zheng Liu
2012-07-31 11:48 ` [PATCH 35/36 v4] tests: change test f_bad_disconnected_inode to support inline_data feature Zheng Liu
2012-07-31 11:48 ` [PATCH 36/36 v4] tune2fs: set " Zheng Liu
2012-09-17 1:06 ` [PATCH 00/36 v4] e2fsprogs: make e2fsprogs support inline data Theodore Ts'o
2012-09-17 2:04 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813081003.GC21093@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).