From: Theodore Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [2/2] ext4: remove unused function argument 'order' in mb_find_extent()
Date: Mon, 13 Aug 2012 10:01:22 -0400 [thread overview]
Message-ID: <20120813140122.GB13521@thunk.org> (raw)
In-Reply-To: <1334298657-20408-2-git-send-email-hao.bigrat@gmail.com>
On Thu, Apr 12, 2012 at 08:30:57PM -0000, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> All the routines call mb_find_extent are setting argument 'order' to 0 just like:
>
> mb_find_extent(e4b, 0, ex.fe_start, ex.fe_len, &ex);
>
> therefore the useless argument should be removed.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2012-08-13 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 6:30 [PATCH 1/2] ext4: remove unused macro MB_DEFAULT_MAX_GROUPS_TO_SCAN Robin Dong
2012-04-13 6:30 ` [PATCH 2/2] ext4: remove unused function argument 'order' in mb_find_extent() Robin Dong
2012-08-13 14:01 ` Theodore Ts'o [this message]
2012-08-13 14:01 ` [1/2] ext4: remove unused macro MB_DEFAULT_MAX_GROUPS_TO_SCAN Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813140122.GB13521@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).