From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 27912] Set 'err' in ext4_init_fs() if kset_create_and_add() fails Date: Wed, 15 Aug 2012 03:03:37 +0000 (UTC) Message-ID: <20120815030337.A6AA011FC6F@bugzilla.kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To: linux-ext4@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.19.201]:58456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800Ab2HODDm (ORCPT ); Tue, 14 Aug 2012 23:03:42 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3BF0220250 for ; Wed, 15 Aug 2012 03:03:41 +0000 (UTC) Received: from bugzilla.kernel.org (unknown [198.145.19.217]) by mail.kernel.org (Postfix) with ESMTP id 294BC2025B for ; Wed, 15 Aug 2012 03:03:39 +0000 (UTC) In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: https://bugzilla.kernel.org/show_bug.cgi?id=27912 --- Comment #4 from Theodore Tso 2012-08-15 03:03:37 --- On Tue, Aug 14, 2012 at 03:55:52PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=27912 Actually, this wasn't quite fixed. Here's a fix which I'll include in the ext4 tree.... - Ted >>From b0f1e9fa10363b60334ba7837080da91de425be0 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Tue, 14 Aug 2012 23:02:17 -0400 Subject: [PATCH] ext4: return an error if kset_create_and_add fails in ext4_init_fs() In the very unlikely case that kset_create_and_add() fails when the ext4.ko module is being loaded (or during kernel startup) set err so that it's clear that the module load failed. https://bugzilla.kernel.org/show_bug.cgi?id=27912 Signed-off-by: "Theodore Ts'o" --- fs/ext4/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index e7ccbe5..603023b 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5281,8 +5281,10 @@ static int __init ext4_init_fs(void) if (err) goto out6; ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj); - if (!ext4_kset) + if (!ext4_kset) { + err = -ENOMEM; goto out5; + } ext4_proc_root = proc_mkdir("fs/ext4", NULL); err = ext4_init_feat_adverts(); -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.