From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, dmonakhov@openvz.org, xfs@oss.sgi.com
Subject: Re: Test 272 fails for ext3
Date: Fri, 17 Aug 2012 08:48:58 +1000 [thread overview]
Message-ID: <20120816224858.GY2877@dastard> (raw)
In-Reply-To: <20120816093757.GA11519@quack.suse.cz>
On Thu, Aug 16, 2012 at 11:37:57AM +0200, Jan Kara wrote:
> Hello,
>
> I was looking into why test 272 from xfstests fails for ext3 and the
> reason is that ext3 does not support direct IO to file with enabled data
> journalling (open returns EINVAL because ->direct_IO callback is not
> specified). So I was thinking how to accomodate this fact in the test -
> the best I found was to just check using xfs_io whether O_DIRECT open
> succeeds and perform the test only in that case. Attached patch does this
> or do people have other ideas?
# ext3 doesn't support direct IO in journalling mode
ext3_write_opt_list="iflag=noatime conv=notrunc conv=fsync"
ext4_write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
if [ $FSTYP = "ext3" ]; then
write_opt_list="$ext3_write_opt_list"
else
write_opt_list="$ext4_write_opt_list"
fi
.....
> diff --git a/272 b/272
> index 26dfa3b..e39c52b 100755
> --- a/272
> +++ b/272
> @@ -52,6 +52,12 @@ _workout()
>
> echo "OP write_opt: $write_opt 4M, \
> chattr_opt: $chattr_opt"
> + if [ "$write_opt" = "oflag=direct" ]; then
> + # Some filesystems don't support direct IO
> + # in some cases, check for that
> + xfs_io -F -d -f -c "" $SCRATCH_MNT/file.$idx \
> + >> $seq.full 2>&1 || continue
> + fi
That only fixes one of the two places that does direct IO on a
jounralled file. The above will fix both...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-16 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 9:28 Test 272 fails for ext3 Jan Kara
2012-08-16 9:37 ` Jan Kara
2012-08-16 10:07 ` Dmitry Monakhov
2012-08-16 22:48 ` Dave Chinner [this message]
2012-08-20 16:22 ` Jan Kara
2012-08-20 21:06 ` Jan Kara
2012-08-20 22:49 ` Dave Chinner
2012-08-21 8:03 ` Jan Kara
2012-09-18 21:26 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816224858.GY2877@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).