From: Theodore Ts'o <tytso@mit.edu>
To: Calvin Walton <calvin.walton@kepstin.ca>
Cc: Andreas Dilger <adilger@dilger.ca>,
Javier Marcet <jmarcet@gmail.com>,
Linux Ext4 Mailing List <linux-ext4@vger.kernel.org>,
jpiszcz@lucidpixels.com
Subject: Re: Far too long mount time
Date: Fri, 17 Aug 2012 09:55:06 -0400 [thread overview]
Message-ID: <20120817135506.GC11439@thunk.org> (raw)
In-Reply-To: <20120816185337.GB31346@thunk.org>
On Thu, Aug 16, 2012 at 02:53:37PM -0400, Theodore Ts'o wrote:
> This patch should solve the problem (as an alternative to reverting
> 8aeb00ff85a).
>
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 603023b..055c65b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3129,6 +3129,10 @@ static int count_overhead(struct super_block *sb, ext4_group_t grp,
> ext4_group_t i, ngroups = ext4_get_groups_count(sb);
> int s, j, count = 0;
>
> + if (!EXT4_HAS_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_BIGALLOC))
> + return (ext4_bg_has_super(sb, grp) + ext4_bg_num_gdb(sb, i) +
^^^
This should be "grp"; stupid typo on my part.
This patch with the fix-up will be pushed to Linus shortly and tagged
for the stable tree.
- Ted
next prev parent reply other threads:[~2012-08-17 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAnFQG_O051svcCZftDefebVEds+P1zAceteh=B18HOqmoqitg@mail.gmail.com>
2012-08-16 7:54 ` Fwd: Far too long mount time Javier Marcet
2012-08-16 9:09 ` Andreas Dilger
2012-08-16 9:18 ` Javier Marcet
2012-08-16 9:53 ` Javier Marcet
2012-08-16 14:16 ` Calvin Walton
2012-08-16 14:42 ` Theodore Ts'o
2012-08-16 18:53 ` Theodore Ts'o
2012-08-16 19:23 ` Eric Sandeen
2012-08-16 19:57 ` Theodore Ts'o
2012-08-17 13:55 ` Theodore Ts'o [this message]
2012-08-17 14:48 ` Justin Piszcz
2012-08-17 14:58 ` Theodore Ts'o
2012-08-17 15:00 ` Justin Piszcz
2012-08-17 15:13 ` Theodore Ts'o
2012-08-17 15:27 ` Theodore Ts'o
2012-08-17 19:18 ` Justin Piszcz
2012-08-17 19:44 ` Eric Sandeen
2012-08-17 15:58 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817135506.GC11439@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=calvin.walton@kepstin.ca \
--cc=jmarcet@gmail.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).