linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: Kevin Liao <kevinlia@gmail.com>,
	Anssi Hannula <anssi.hannula@iki.fi>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] resize2fs: fix overhead calculation for meta_bg file systems
Date: Mon, 3 Sep 2012 22:14:12 -0400	[thread overview]
Message-ID: <20120904021412.GG5066@thunk.org> (raw)
In-Reply-To: <CAGBYx2a8J1ZvWDjgv3snTCE59nqurF_sGYJ0pxSy2anXjzfBRg@mail.gmail.com>

On Tue, Sep 04, 2012 at 09:59:55AM +0800, Yongqiang Yang wrote:
> Hi Kevin,
> 
>   Ted has sent out the patches on online resizing for meta_bg and
> 64bits, so you can have a try again. It seems that the bug in
> e2fsprogs has been fixed.

Make sure you use the latest version of the kernel patches that I just
sent out.  There quite a number of bugs in the Yongqiang's original
patch set which I tripped over while I was testing 64-bit resize ---
and please note that there are definitely still rough edges
(especially for in cases where the file system was created < 16TB, but
with the 64-bit feature and resize_inode features enabled).  There may
also be bugs for the straightforward case of resizing very large file
systems.

So while I very much appreciate users giving the code a try and
sending us feedback, please do think twice before using this code on
file systems with data that hasn't been backed up recently.  (Of
course, being good System Administrators you are all keeping --- and
verifying --- regular backups, right?  :-)

Regards,

						- Ted

  parent reply	other threads:[~2012-09-04  2:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02  9:52 [PATCH] resize2fs: support online-resizing for meta_bg and 64bits features Yongqiang Yang
2012-09-02 10:31 ` Yongqiang Yang
2012-09-03  0:50   ` Theodore Ts'o
2012-09-03 16:45   ` Theodore Ts'o
2012-09-03 16:45     ` [PATCH 1/2] resize2fs: allow meta_bg/64-bit file systems to be online resized Theodore Ts'o
2012-09-03 16:45       ` [PATCH 2/2] resize2fs: fix overhead calculation for meta_bg file systems Theodore Ts'o
2012-09-04  1:59         ` Yongqiang Yang
2012-09-04  2:14           ` Kevin Liao
2012-09-04  2:14           ` Theodore Ts'o [this message]
2012-09-04 17:05             ` Anssi Hannula
2012-09-05  2:10               ` Yongqiang Yang
2012-09-05  4:55                 ` Theodore Ts'o
2012-09-05  5:16                   ` Yongqiang Yang
2012-09-05  5:38                     ` Theodore Ts'o
2012-09-06 14:22                 ` Anssi Hannula
2012-09-06 16:19                   ` Yongqiang Yang
2012-09-05  6:32             ` Kevin Liao
2012-09-05  6:44               ` Yongqiang Yang
2012-09-05  6:50                 ` Kevin Liao
2012-09-13 23:21               ` Theodore Ts'o
2012-09-14  3:24                 ` Kevin Liao
2012-09-04  2:02         ` Yongqiang Yang
2012-09-03 21:02     ` [PATCH] resize2fs: support online-resizing for meta_bg and 64bits features Kai Grosshaus
2012-09-03 23:00       ` Theodore Ts'o
2012-09-03 23:33         ` Kai Großhaus
2012-09-04  2:01     ` Yongqiang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904021412.GG5066@thunk.org \
    --to=tytso@mit.edu \
    --cc=anssi.hannula@iki.fi \
    --cc=kevinlia@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).