From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] ext4: serialize truncate with owerwrite DIO workers
Date: Wed, 5 Sep 2012 21:05:43 +0200 [thread overview]
Message-ID: <20120905190543.GL18051@quack.suse.cz> (raw)
In-Reply-To: <87y5ko76ea.fsf@openvz.org>
On Wed 05-09-12 20:59:09, Dmitry Monakhov wrote:
> On Wed, 5 Sep 2012 17:49:20 +0200, Jan Kara <jack@suse.cz> wrote:
> > On Tue 04-09-12 21:36:54, Dmitry Monakhov wrote:
> > > Jan Kara have spotted interesting issue:
> > > There are potential data corruption issue with direct IO overwrites
> > > racing with truncate:
> > > Like:
> > > dio write truncate_task
> > > ->ext4_ext_direct_IO
> > > ->overwrite == 1
> > > ->down_read(&EXT4_I(inode)->i_data_sem);
> > > ->mutex_unlock(&inode->i_mutex);
> > > ->ext4_setattr()
> > > ->inode_dio_wait()
> > > ->truncate_setsize()
> > > ->ext4_truncate()
> > > ->down_write(&EXT4_I(inode)->i_data_sem);
> > > ->__blockdev_direct_IO
> > > ->ext4_get_block
> > > ->submit_io()
> > > ->up_read(&EXT4_I(inode)->i_data_sem);
> > > # truncate data blocks, allocate them to
> > > # other inode - bad stuff happens because
> > > # dio is still in flight.
> > >
> > > In order to serialize with truncate dio worker should grab extra i_dio_count
> > > reference before drop i_mutex.
> > Thanks for the patch. You can add:
> > Reviewed-by: Jan Kara <jack@suse.cz>
> I'm Sorry, but unfortunately in two line patch i've done one mistake :(
> because inode_dio_done() should be before i_mutex will be retaken
> otherwise following deadlock happen
>
> ext4_setattr ext4_direct_io
> mutex_unlock
> atomic_inc(inode->i_dio_count)
> mutex_lock(i_mutex)
> inode_dio_wait(inode) ->BLOCK
> DEADLOCK<- mutex_lock(i_mutex)
> inode_dio_done()
>
> So i'll add your review sing to updated version if you don't mind.
Sure. I should have noticed that as well...
Honza
> > > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> > > ---
> > > fs/ext4/inode.c | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> > > index 5a75908..9725acb 100644
> > > --- a/fs/ext4/inode.c
> > > +++ b/fs/ext4/inode.c
> > > @@ -3035,6 +3035,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> > > overwrite = *((int *)iocb->private);
> > >
> > > if (overwrite) {
> > > + atomic_inc(&inode->i_dio_count);
> > > down_read(&EXT4_I(inode)->i_data_sem);
> > > mutex_unlock(&inode->i_mutex);
> > > }
> > > @@ -3134,6 +3135,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> > > if (overwrite) {
> > > up_read(&EXT4_I(inode)->i_data_sem);
> > > mutex_lock(&inode->i_mutex);
> > > + inode_dio_done(inode);
> > > }
> > >
> > > return ret;
> > > --
> > > 1.7.7.6
> > >
> > --
> > Jan Kara <jack@suse.cz>
> > SUSE Labs, CR
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-09-05 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 17:36 [PATCH 1/4] ext4: serialize dio nonlocked reads with defrag workers Dmitry Monakhov
2012-09-04 17:36 ` [PATCH 2/4] ext4: serialize unlocked dio reads with truncate Dmitry Monakhov
2012-09-04 17:36 ` [PATCH 3/4] ext4: endless truncate due to nonlocked dio readers V2 Dmitry Monakhov
2012-09-04 17:36 ` [PATCH 4/4] ext4: serialize truncate with owerwrite DIO workers Dmitry Monakhov
2012-09-05 15:49 ` Jan Kara
2012-09-05 16:59 ` Dmitry Monakhov
2012-09-05 19:05 ` Jan Kara [this message]
2012-09-06 10:07 ` Dmitry Monakhov
2012-09-05 15:47 ` [PATCH 1/4] ext4: serialize dio nonlocked reads with defrag workers Jan Kara
2012-09-05 17:09 ` Dmitry Monakhov
-- strict thread matches above, loose matches on Subject: below --
2012-09-04 17:22 Dmitry Monakhov
2012-09-04 17:22 ` [PATCH 4/4] ext4: serialize truncate with owerwrite DIO workers Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905190543.GL18051@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).