From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>,
Eryu Guan <eguan@redhat.com>, xfs-oss <xfs@oss.sgi.com>,
Zach Brown <zab@redhat.com>
Subject: Re: [PATCH V3] xfstests: make 275 pass
Date: Sat, 8 Sep 2012 10:09:54 +1000 [thread overview]
Message-ID: <20120908000954.GW15292@dastard> (raw)
In-Reply-To: <504A5176.5020302@sandeen.net>
On Fri, Sep 07, 2012 at 02:56:38PM -0500, Eric Sandeen wrote:
> On 1/25/12 3:13 PM, Eric Sandeen wrote:
> > Ok, this is a significant rework of 275, which made too many
> > assumptions about details of space usage and failed on several
> > filesystems (it passed on xfs, but only by accident).
> >
> > This new version tries to leave about 256k free, then tries
> > a single 1M IO, and fails only if 0 bytes are written.
> >
> > It also sends a lot more to $seq.full for debugging on failure
> > and fixes a few other stylistic things.
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > ---
>
> Poor Zach ran into this one again. Can I get a review of this
> version, and I'll merge it if it looks good?
Looks OK.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-09-08 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 19:22 [PATCH] xfstests: make 275 pass on ext4 Eric Sandeen
2012-01-04 19:37 ` Eric Sandeen
2012-01-04 20:54 ` [PATCH V2] xfstests: make 275 pass Eric Sandeen
2012-01-04 23:17 ` Dave Chinner
2012-01-04 23:21 ` Eric Sandeen
2012-01-05 0:39 ` Dave Chinner
2012-01-17 16:33 ` Eric Sandeen
2012-01-25 21:13 ` [PATCH V3] " Eric Sandeen
2012-09-07 19:56 ` Eric Sandeen
2012-09-08 0:09 ` Dave Chinner [this message]
2012-01-18 2:42 ` [PATCH V2] " Liu Bo
2012-01-18 4:03 ` Eric Sandeen
2012-01-18 4:42 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908000954.GW15292@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).