From: Fengguang Wu <fengguang.wu@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: ext4: convert file system to meta_bg if needed during resizing
Date: Tue, 18 Sep 2012 19:52:22 +0800 [thread overview]
Message-ID: <20120918115222.GA17551@localhost> (raw)
In-Reply-To: <20120918114634.GA12383@elgon.mountain>
On Tue, Sep 18, 2012 at 02:46:35PM +0300, Dan Carpenter wrote:
> Hello Theodore Ts'o,
>
> The patch 1c6bd7173d66: "ext4: convert file system to meta_bg if
> needed during resizing" from Sep 13, 2012, leads to the following
> warning:
> fs/ext4/resize.c:1829 ext4_convert_meta_bg()
> error: potential NULL dereference 'ei'.
>
> 1770 static int ext4_convert_meta_bg(struct super_block *sb, struct inode *inode)
> 1771 {
> 1772 handle_t *handle;
> 1773 struct ext4_sb_info *sbi = EXT4_SB(sb);
> 1774 struct ext4_super_block *es = sbi->s_es;
> 1775 struct ext4_inode_info *ei = 0;
> ^^^^^^
> Sparse is going to complain. Not sure why Fengguang hasn't emailed you.
Sorry I'm doing lots of changes these days and they apparently break
many things.. I'd expect the build test system to gradually restore to
normal in the coming days.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-09-18 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 11:46 ext4: convert file system to meta_bg if needed during resizing Dan Carpenter
2012-09-18 11:52 ` Fengguang Wu [this message]
2012-09-19 3:51 ` Theodore Ts'o
2012-09-19 4:56 ` [PATCH] ext4: fix online resizing when the # of block groups is constant Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2020-02-29 0:39 ext4: convert file system to meta_bg if needed during resizing Colin Ian King
2020-02-29 17:42 ` Theodore Y. Ts'o
2020-02-29 17:52 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918115222.GA17551@localhost \
--to=fengguang.wu@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).