From: Theodore Ts'o <tytso@mit.edu>
To: linux-ext4@vger.kernel.org
Subject: Re: [v2] ext4: fix possible non-initialized variable
Date: Fri, 21 Sep 2012 20:52:02 -0400 [thread overview]
Message-ID: <20120922005202.GD27207@thunk.org> (raw)
In-Reply-To: <20120921191449.GA18336@andromeda.usersys.redhat.com>
On Fri, Sep 21, 2012 at 04:14:49PM -0300, Carlos Maiolino wrote:
> Not a bad idea really.
>
> I've found some functions properly handling the problem (i.e !bh and !err), but
> some of them not. I'm thinking in fix functions with missing hole handlers and
> after that think about a 'default directory hole handler' for this, instead of
> make each function work on a specific way.
I'd have to take a look at a patch, but I didn't think there would be
enough code to be worth factoring out into a separate function. It's
just a conditional, a call to ext4_error(), and then setting up the
return code and releasing resources that need to be released on our
way out (which tends to be function-specific).
Am I missing something?
- Ted
prev parent reply other threads:[~2012-09-22 0:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 21:55 [PATCH v2] ext4: fix possible non-initialized variable Carlos Maiolino
2012-09-15 18:30 ` [v2] " Theodore Ts'o
2012-09-17 14:55 ` Eric Sandeen
2012-09-17 15:30 ` Eric Sandeen
2012-09-17 15:37 ` Theodore Ts'o
2012-09-17 18:26 ` Carlos Maiolino
2012-09-18 3:59 ` Theodore Ts'o
2012-09-18 12:51 ` Carlos Maiolino
2012-09-19 20:10 ` Carlos Maiolino
2012-09-19 20:41 ` Theodore Ts'o
2012-09-20 2:59 ` Eric Sandeen
2012-09-21 19:14 ` Carlos Maiolino
2012-09-22 0:52 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922005202.GD27207@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).