From: Theodore Ts'o <tytso@mit.edu>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: ext4_bread usage audit
Date: Tue, 25 Sep 2012 23:42:40 -0400 [thread overview]
Message-ID: <20120926034240.GE11468@thunk.org> (raw)
In-Reply-To: <1348512100-23323-1-git-send-email-cmaiolino@redhat.com>
On Mon, Sep 24, 2012 at 03:41:40PM -0300, Carlos Maiolino wrote:
>
> Some ext4_bread callers do not needed any changes either because they already
> had its own hole detector paths or because these are deprecaded (like
> dx_show_entries)
BTW, dx_show entries isn't really deprecated; is debugging code which
is usually not compiled in, but it does get used from time to time by
developers who are debugging the directory hash tree code...
So having it show the holes by printing a note that there _was_ a
whole is probably a good thing from a debugging point of view...
- Ted
next prev parent reply other threads:[~2012-09-26 3:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 18:41 [PATCH] ext4: ext4_bread usage audit Carlos Maiolino
2012-09-25 6:38 ` Andreas Dilger
2012-09-26 3:42 ` Theodore Ts'o [this message]
2012-09-26 3:48 ` Eric Sandeen
2012-09-26 14:14 ` Carlos Maiolino
2012-09-27 13:29 ` Andreas Dilger
2012-09-27 13:20 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926034240.GE11468@thunk.org \
--to=tytso@mit.edu \
--cc=cmaiolino@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).