From: Dave Chinner <david@fromorbit.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@lst.de, xfs@oss.sgi.com
Subject: Re: [PATCH 2/6] xfstest: add configurable load factors
Date: Thu, 27 Sep 2012 10:06:38 +1000 [thread overview]
Message-ID: <20120927000638.GC15236@dastard> (raw)
In-Reply-To: <1348496601-32637-2-git-send-email-dmonakhov@openvz.org>
On Mon, Sep 24, 2012 at 06:23:17PM +0400, Dmitry Monakhov wrote:
> Most stress test has probable behaviour, the longer test run the
> larger corner cases will be cover. It is reasonable to allow
> user to provide some sort of system load factor.
> This patch introduce two global variables
> LOAD_FACTOR: Usually means factor number of running tasks
> TIME_FACTOR: Usually means factor of run time, or number of operations
> If not speficied both variables defined to 1, so original behaviour
> preserved.
>
> TODO: Change all stress tests to use this variables
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> common.config | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/common.config b/common.config
> index d5c8956..cfa7bde 100644
> --- a/common.config
> +++ b/common.config
> @@ -253,5 +253,13 @@ if [ ! -z "$SCRATCH_MNT" -a ! -d "$SCRATCH_MNT" ]; then
> exit 1
> fi
>
> +if [ -z "$LOAD_FACTOR" ]; then
> + LOAD_FACTOR=1
> +fi
> +
> +if [ -z "$TIME_FACTOR" ]; then
> + TIME_FACTOR=1
> +fi
They probably need to be exparted variables set up through the
check script, not somthing sourced via common.config. i.e. something
like this in check where the environment is being set up:
export TIME_FACTOR=${TIME_FACTOR:=1}
export LOAD_FACTOR=${LOAD_FACTOR:=1}
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-09-27 0:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:23 [PATCH 1/6] xfstests: add fio requirement V2 Dmitry Monakhov
2012-09-24 14:23 ` [PATCH 2/6] xfstest: add configurable load factors Dmitry Monakhov
2012-09-27 0:06 ` Dave Chinner [this message]
2012-09-24 14:23 ` [PATCH 3/6] xfstest: allow fsstress to use load factor where appropriate Dmitry Monakhov
2012-09-27 0:19 ` Dave Chinner
2012-09-24 14:23 ` [PATCH 4/6] add fallocate/truncate vs AIO/DIO stress test Dmitry Monakhov
2012-09-27 1:05 ` Dave Chinner
2012-09-24 14:23 ` [PATCH 5/6] add fallocate/punch_hole " Dmitry Monakhov
2012-09-27 1:07 ` Dave Chinner
2012-09-24 14:23 ` [PATCH 6/6] add defragmentation stress test for ext4 Dmitry Monakhov
2012-09-27 1:15 ` Dave Chinner
2012-09-27 0:19 ` [PATCH 1/6] xfstests: add fio requirement V2 Dave Chinner
[not found] <a>
2012-09-23 19:24 ` [PATCH 1/6] xfstest: add fio git submodule Dmitry Monakhov
2012-09-23 19:24 ` [PATCH 2/6] xfstest: add configurable load factors Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927000638.GC15236@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).