From: Theodore Ts'o <tytso@mit.edu>
To: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Cc: "linux-ext4@vger.kernel.org List" <linux-ext4@vger.kernel.org>
Subject: Re: ext4: ext4_mknod: always set i_op
Date: Wed, 26 Sep 2012 21:25:35 -0400 [thread overview]
Message-ID: <20120927012535.GA28586@thunk.org> (raw)
In-Reply-To: <504782F8.2080005@itwm.fraunhofer.de>
On Wed, Sep 05, 2012 at 06:51:04AM -0000, Bernd Schubert wrote:
> While I was looking through the code, I noticed i_op
> is not always initialized, although operations such
> as setattr probably always should be set.
>
>
> ext4: ext4_mknod: always set i_op
>
> From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
>
> ext4_special_inode_operations have their own ifdef CONFIG_EXT4_FS_XATTR
> to mask those methods. And ext4_iget also always sets it, so there is
> an inconsistency.
>
> Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Applied, thanks!!
- Ted
prev parent reply other threads:[~2012-09-27 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 16:51 [PATCH] ext4: ext4_mknod: always set i_op Bernd Schubert
2012-09-27 1:25 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927012535.GA28586@thunk.org \
--to=tytso@mit.edu \
--cc=bernd.schubert@itwm.fraunhofer.de \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).