From: Theodore Ts'o <tytso@mit.edu>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: next/mmotm: ext4 causes !rwsem_is_locked warnings
Date: Thu, 27 Sep 2012 17:27:08 -0400 [thread overview]
Message-ID: <20120927212708.GA10044@thunk.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1209271334560.2226@eggly.anvils>
On Thu, Sep 27, 2012 at 02:05:00PM -0700, Hugh Dickins wrote:
> Hi Ted,
>
> mmotm (or next) now gives me lots of WARNING at fs/fs-writeback.c:1312 from
> writeback_inodes_sb_nr(). That's WARN_ON(!rwsem_is_locked(&sb->s_umount))
> (some useful safety from hch) in writeback_inodes_sb_nr().
>
> Your commit 40e684e5c597a98996cf4616e31fb2581ec82060
> "ext4: fix potential deadlock in ext4_nonda_switch()" needs more change
> to fs/fs-writeback.c. I guess I'm the only one using a nearly full ext4.
>
> I am, of course, applying the patch at the bottom to my tree for now;
> but I think you'd do better not to eliminate that check. Maybe add a
> special wb_reason for your case, and skip rwsem check in that case.
Yeah, we were just discussing this on another thread. I didn't think
of the option of creating a new special wb_reason option, but that's a
much better option than the other ones I had been considering, so I
think I will give that a try. Thanks for the suggestion!!
- Ted
next prev parent reply other threads:[~2012-09-27 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 21:05 next/mmotm: ext4 causes !rwsem_is_locked warnings Hugh Dickins
2012-09-27 21:27 ` Theodore Ts'o [this message]
2012-09-28 3:31 ` [PATCH v2] ext4: fix potential deadlock in ext4_nonda_switch() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927212708.GA10044@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).