From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix ext4_flush_completed_IO wait semantics
Date: Fri, 5 Oct 2012 00:20:59 -0400 [thread overview]
Message-ID: <20121005042059.GC11723@thunk.org> (raw)
In-Reply-To: <20121004101106.GC4641@quack.suse.cz>
On Thu, Oct 04, 2012 at 12:11:06PM +0200, Jan Kara wrote:
> > retry:
> > if (rw == READ && ext4_should_dioread_nolock(inode)) {
> > - if (unlikely(!list_empty(&ei->i_completed_io_list)))
> > - ext4_flush_completed_IO(inode);
> > -
> > + if (unlikely(!atomic_read(&EXT4_I(inode)->i_unwritten))) {
> This condition which seems to be inverted...
Nice catch, thanks! I've fixed this in my tree.
- Ted
next prev parent reply other threads:[~2012-10-05 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 18:43 [PATCH] ext4: fix ext4_flush_completed_IO wait semantics Dmitry Monakhov
2012-10-03 18:55 ` Theodore Ts'o
2012-10-03 19:32 ` Dmitry Monakhov
2012-10-03 20:24 ` Theodore Ts'o
2012-10-04 10:11 ` Jan Kara
2012-10-05 4:20 ` Theodore Ts'o [this message]
2012-10-05 12:40 ` Theodore Ts'o
2012-10-05 13:01 ` Dmitry Monakhov
2012-10-05 13:28 ` Theodore Ts'o
2012-10-05 13:53 ` Dmitry Monakhov
2012-10-05 14:20 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005042059.GC11723@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).