From: Theodore Ts'o <tytso@mit.edu>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
linux-ext4@vger.kernel.org, jack@suse.cz, lczerner@redhat.com
Subject: Re: [PATCH 05/11] ext4: remove ext4_end_io()
Date: Fri, 5 Oct 2012 00:28:16 -0400 [thread overview]
Message-ID: <20121005042816.GD11723@thunk.org> (raw)
In-Reply-To: <CAOMFOmVyqmmepkVOYSjz7kYtqGb0ogpyOzMYAX4KiA9JKBMKaQ@mail.gmail.com>
I ended up dropping this patch since it doesn't make any difference to
the generated code (gcc will take a static function which is only used
in one place, and inline it) and it makes a bit more understandable to
have ext4_end_io() as a separate function.
> > + /* Wake up anyone waiting on unwritten extent conversion */
> > + if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten))
> > + wake_up_all(ext4_ioend_wq(io->inode));
>
> Should we use "inode" instead of "io->inode"?
I agree it would be a bit cleaner/more readable, but again it won't
make a difference to the generated assembly, and while we oculd do
this in the original code in ext4_end_io(), I'm trying to put this
patch series to bed so I can push it to Linus, and since we're now not
touching the code, it's not worth it to clean this up now. We can
take of this later....
- Ted
next prev parent reply other threads:[~2012-10-05 7:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 15:44 [PATCH 00/11] ext4: Bunch of DIO/AIO fixes V4 Dmitry Monakhov
2012-09-28 15:44 ` [PATCH 01/11] ext4: ext4_inode_info diet Dmitry Monakhov
2012-10-01 16:28 ` Jan Kara
2012-09-28 15:44 ` [PATCH 02/11] ext4: give i_aiodio_unwritten more appropriate name Dmitry Monakhov
2012-09-28 15:44 ` [PATCH 03/11] ext4: fix unwritten counter leakage Dmitry Monakhov
2012-10-01 16:37 ` Jan Kara
2012-09-28 15:44 ` [PATCH 04/11] ext4: completed_io locking cleanup V4 Dmitry Monakhov
2012-10-01 18:38 ` Jan Kara
2012-10-02 7:16 ` Dmitry Monakhov
2012-10-02 10:31 ` Jan Kara
2012-10-02 10:57 ` Dmitry Monakhov
2012-10-02 11:11 ` Jan Kara
2012-10-02 12:42 ` Dmitry Monakhov
2012-10-02 13:30 ` Jan Kara
2012-10-03 11:21 ` Dmitry Monakhov
2012-10-04 10:22 ` Jan Kara
2012-09-28 15:44 ` [PATCH 05/11] ext4: remove ext4_end_io() Dmitry Monakhov
2012-10-04 22:57 ` Anatol Pomozov
2012-10-05 4:28 ` Theodore Ts'o [this message]
2012-09-28 15:44 ` [PATCH 06/11] ext4: serialize dio nonlocked reads with defrag workers V3 Dmitry Monakhov
2012-10-01 16:39 ` Jan Kara
2012-09-28 15:44 ` [PATCH 07/11] ext4: serialize unlocked dio reads with truncate Dmitry Monakhov
2012-09-29 4:49 ` Theodore Ts'o
2012-09-29 11:43 ` Dmitry Monakhov
2012-09-28 15:44 ` [PATCH 08/11] ext4: endless truncate due to nonlocked dio readers V2 Dmitry Monakhov
2012-10-01 16:41 ` Jan Kara
2012-09-28 15:44 ` [PATCH 09/11] ext4: serialize truncate with owerwrite DIO workers V2 Dmitry Monakhov
2012-09-28 15:44 ` [PATCH 10/11] ext4: punch_hole should wait for DIO writers V2 Dmitry Monakhov
2012-10-01 16:46 ` Jan Kara
2012-09-28 15:44 ` [PATCH 11/11] ext4: fix ext_remove_space for punch_hole case Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005042816.GD11723@thunk.org \
--to=tytso@mit.edu \
--cc=anatol.pomozov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).