From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 16/21 v5] e2fsck: add problem descriptions and check inline data feature
Date: Sun, 14 Oct 2012 09:22:10 -0400 [thread overview]
Message-ID: <20121014132210.GB6207@thunk.org> (raw)
In-Reply-To: <1348286469-31690-17-git-send-email-wenqing.lz@taobao.com>
Hi Zheng,
I was trying to apply these patches to the e2fsprogs pu branch, and as
a matter of course, I ran checkpatch on the patch series. The reason
why it's useful is because it finds stuff like this:
WARNING: trailing semicolon indicates no statements, indent implies otherwise
#156: FILE: lib/ext2fs/inline_data.c:567:
+ if (retval);
+ return pass;
ERROR: trailing statements should be on next line
#156: FILE: lib/ext2fs/inline_data.c:567:
+ if (retval);
> +int ext2fs_inline_data_header_check(ext2_filsys fs, ext2_ino_t ino)
> +{
> + struct ext2_inode_large *inode;
> + struct inline_data data;
> + errcode_t retval = 0;
> + int pass = 0;
> +
> + retval = ext2fs_get_mem(EXT2_INODE_SIZE(fs->super), &inode);
> + if (retval);
> + return pass;
This means the rest of ext2fs_inline_data_header_check() isn't getting
executed, since the "return pass;" statement would get executed
unconditionally. I didn't try it, but I suspect "make gcc-wall"
probably would have turned up this typo as well.
I'll fix this in my tree on the pu branch; I'm still looking over the
rest of the patches, but I thought it would be good to point this out
first.
Cheers,
- Ted
next prev parent reply other threads:[~2012-10-14 14:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 4:00 [PATCH 00/21 v5] e2fsprogs: make e2fsprogs support inline data Zheng Liu
2012-09-22 4:00 ` [PATCH 01/21 v5] libext2fs: add INLINE_DATA into EXT2_LIB_SOFTSUPP_INCOMPAT Zheng Liu
2012-09-22 4:00 ` [PATCH 02/21 v5] libext2fs: add function to check inline_data flag for an inode Zheng Liu
2012-09-22 4:00 ` [PATCH 03/21 v5] libext2fs: add functions to operate extend attribute Zheng Liu
2012-09-22 4:00 ` [PATCH 04/21 v5] libext2fs: handle inline data in dir iterator function Zheng Liu
2012-09-22 4:00 ` [PATCH 05/21 v5] libext2fs: handle inline_data in block " Zheng Liu
2012-09-22 4:00 ` [PATCH 06/21 v5] debugfs: make stat command support inline data Zheng Liu
2012-09-22 4:00 ` [PATCH 07/21 v5] libext2fs: handle inline data when expanding directory Zheng Liu
2012-09-22 4:00 ` [PATCH 08/21 v5] debugfs: make lsdel command support inline data Zheng Liu
2012-09-22 4:00 ` [PATCH 09/21 v5] libext2fs: handle inline data in read/write function Zheng Liu
2012-09-22 4:00 ` [PATCH 10/21 v5] debugfs: handle inline_data feature in dirsearch command Zheng Liu
2012-09-22 4:00 ` [PATCH 11/21 v5] debugfs: handle inline_data feature in bmap command Zheng Liu
2012-09-22 4:01 ` [PATCH 12/21 v5] debugfs: handle inline_data in punch command Zheng Liu
2012-09-22 4:01 ` [PATCH 13/21 v5] libext2fs: add inline_data feature into EXT2_LIB_FEATURE_INCOMPAT_SUPP Zheng Liu
2012-09-22 4:01 ` [PATCH 14/21 v5] mke2fs: add inline_data support in mke2fs Zheng Liu
2012-09-22 4:01 ` [PATCH 15/21 v5] tune2fs: add inline_data feature in tune2fs Zheng Liu
2012-09-22 4:01 ` [PATCH 16/21 v5] e2fsck: add problem descriptions and check inline data feature Zheng Liu
2012-10-14 13:22 ` Theodore Ts'o [this message]
2012-10-14 23:34 ` Zheng Liu
2012-09-22 4:01 ` [PATCH 17/21 v5] e2fsck: check inline_data in pass1 Zheng Liu
2012-09-22 4:01 ` [PATCH 18/21 v5] e2fsck: check inline_data in pass2 Zheng Liu
2012-09-22 4:01 ` [PATCH 19/21 v5] e2fsck: check inline_data in pass3 Zheng Liu
2012-09-22 4:01 ` [PATCH 20/21 v5] tests: change result in f_bad_disconnected_inode Zheng Liu
2012-09-22 4:01 ` [PATCH 21/21 v5] mke2fs: enable inline_data feature on ext4dev filesystem Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121014132210.GB6207@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).