A question about the naming of e2fsprogs/tests

A question about the naming of e2fsprogs/tests

[Zheng Liu]

Hi All,

Now I am trying to create some regression tests for e2fsprogs to test
inline data feature.  I have a question about the naming of
e2fsprogs/tests.  I notice that in tests dir there are a lot of
directories, which have different prefixes, such as d_loaddump,
e_brel_bma, f_baddir, m_dasd_bs, r_move_itable, t_mmp_1on, and u_mke2fs.
As far as I can understand, d_ is for debugfs, f_ means test for filesystem,
m_ is for mke2fs, r_ is for resize2fs, t_ is for tune2fs, and u_ is for e2undo.
Could anyone tell me what e_ stands for?  If I misunderstand something, please
point it out.  Thanks.

Regards,
Zheng

Re: A question about the naming of e2fsprogs/tests

[Theodore Ts'o]

On Wed, Oct 17, 2012 at 09:13:51PM +0800, Zheng Liu wrote:
> 
> Now I am trying to create some regression tests for e2fsprogs to test
> inline data feature.  I have a question about the naming of
> e2fsprogs/tests.  I notice that in tests dir there are a lot of
> directories, which have different prefixes, such as d_loaddump,
> e_brel_bma, f_baddir, m_dasd_bs, r_move_itable, t_mmp_1on, and u_mke2fs.
> As far as I can understand, d_ is for debugfs, f_ means test for filesystem,
> m_ is for mke2fs, r_ is for resize2fs, t_ is for tune2fs, and u_ is for e2undo.
> Could anyone tell me what e_ stands for?  If I misunderstand something, please
> point it out.  Thanks.

The e_ calls were for unit tests for the "extent" functions --- where
extents are not the ext4 extents, but some utility functions which
were are used by resize2fs.  These days we generally don't use the
tests directory for unit tests, because it's a lot more work to do
things that way.  Instead there are tst_* files in lib/ext2fs that are
built and run with "make check".

I *do* ask that people who create new functions in libext2fs strongly
consider adding unit tests.  We are pretty good with integration tests
in the tests directory, but we are a bit light on unit tests coverage
in lib/ext2fs.

And of course, if someone is inspired to write some new unit tests for
existing functions, that would just great.

Thanks!!

						- Ted