From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: George Spelvin <linux@horizon.com>,
linux-ext4@vger.kernel.org, tm@tao.ma
Subject: Re: ext4: fix metadata checksum calculation for the superblock
Date: Wed, 31 Oct 2012 20:22:49 -0700 [thread overview]
Message-ID: <20121101032249.GH19591@blackbox.djwong.org> (raw)
In-Reply-To: <20121101015015.GA28919@thunk.org>
On Wed, Oct 31, 2012 at 09:50:15PM -0400, Theodore Ts'o wrote:
> On Wed, Oct 31, 2012 at 06:13:12PM -0700, Darrick J. Wong wrote:
> > > Author: Theodore Ts'o <tytso@mit.edu>
> > > Date: Sun Oct 7 22:18:56 2012 -0400
> > > Subject: ext4: fix metadata checksum calculation for the superblock
>
> This one was cc'ed to stable@vger.kernel.org. But when you said "I
> notice, that neither of thse have made it into 2.6.5", I assume you
> meant 3.5? The last 3.5 kernel is 3.5.7, and Greg K-H isn't
> backporting fixes to 3.5.x any more. (See http://www.kernel.org to
> see which kernels are marked "EOL"; those are the ones which are no
> longer getting updates.)
>
> So that means it should eventually make it to the 3.4.x and 3.6.x
> kernels.
I thought he meant 3.6.5, but I haven't really been paying 3.6.x much attention.
> > > Author: Darrick J. Wong <darrick.wong@oracle.com>
> > > Date: Wed Oct 17 12:51:30 2012 -0700
> > > Subject: ext4: Don't verify checksums of dx non-leaf nodes during fallback linear scan
>
> I missed this one because the subject line didn't have [PATCH] in it.
> (Darrick, it really helps if you use git format-patch / git
> send-email; you can use a message-id of the message you're replying to
> in the mail thread to chain the message to the thread.)
>
> I would have eventually found it in patchwork, but even in patchwork
> the listing would have had a potentially misleading subject line,
> since it grabs the patch title from the subject line of the e-mail.
Oops, I guess I did forget the magic "[PATCH]". Sorry about that.
> > <shrug> I was wondering too, but I figured Ted was probably busy dealing with
> > the corruption bug and such.
> >
> > (Which itself doesn't seem to be in 3.6.x yet)
>
> It isn't in 3.7-rc3 because I didn't see it before I sent the pull
> request to Linus....
>
> At this point I'll just include it in the patches to be sent to Linus
> at the next merge window, mainly because I don't have the time to run
> a separate regression test run just for this patch, and it's only a
> cosmetic issue, right?
Yep.
--D
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-01 3:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 5:04 metadata_csum + unclean shutdown = failure to boot George Spelvin
2012-10-07 13:39 ` Tao Ma
2012-10-07 15:09 ` George Spelvin
2012-10-07 18:10 ` Theodore Ts'o
2012-10-07 20:18 ` George Spelvin
2012-10-07 22:54 ` Theodore Ts'o
2012-10-08 1:05 ` George Spelvin
2012-10-08 1:25 ` George Spelvin
2012-10-08 2:41 ` Theodore Ts'o
2012-10-08 3:17 ` George Spelvin
2012-10-08 4:03 ` Tao Ma
2012-10-08 11:35 ` George Spelvin
2012-11-01 1:05 ` ext4: fix metadata checksum calculation for the superblock George Spelvin
2012-11-01 1:13 ` Darrick J. Wong
2012-11-01 1:50 ` Theodore Ts'o
2012-11-01 3:22 ` Darrick J. Wong [this message]
2012-11-01 6:12 ` George Spelvin
2012-11-01 6:49 ` Darrick J. Wong
2012-11-01 7:07 ` George Spelvin
2012-11-01 7:18 ` Darrick J. Wong
2012-11-01 7:28 ` George Spelvin
2012-11-02 0:05 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101032249.GH19591@blackbox.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux@horizon.com \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).