From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Behan Webster <behanw@converseincode.com>,
linux-ext4@vger.kernel.org, Mark Charlebois <charlebm@gmail.com>
Subject: Re: [PATCH] Remove VLAIS usage from JBD2 code
Date: Thu, 8 Nov 2012 10:53:07 -0500 [thread overview]
Message-ID: <20121108155307.GB766@thunk.org> (raw)
In-Reply-To: <20121030191307.GC19576@blackbox.djwong.org>
Hey Darrick,
I was looking at this code a bit more closely while applying the
revised version of this patch --- and this in particular raised a red
flag for me:
*(u32 *)desc.ctx = crc;
...
return *(u32 *)desc.ctx;
Does this raise any byte swapping issues? Looking at how the crc32
code in crypto/ works, I'm almost certain this is broken on big-endian
systems, and we need to add le32_to_cup() and cpu_to_le32() calls here.
Am I missing something?
- Ted
next prev parent reply other threads:[~2012-11-08 22:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:40 [PATCH] Removing the use of VLAIS from the Linux Kernel Behan Webster
2012-10-30 18:40 ` [PATCH] Remove VLAIS usage from JBD2 code Behan Webster
2012-10-30 19:00 ` Theodore Ts'o
2012-10-30 19:02 ` Behan Webster
2012-10-30 19:13 ` Darrick J. Wong
2012-11-08 15:53 ` Theodore Ts'o [this message]
2012-11-09 23:19 ` Darrick J. Wong
2012-11-09 23:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108155307.GB766@thunk.org \
--to=tytso@mit.edu \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).